Skip to content

Fix eldritch implicits not removed when their influence is removed - #10513

Open
lucaskarsten wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
lucaskarsten:fix/4941-eldritch-influence
Open

lucaskarsten wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
lucaskarsten:fix/4941-eldritch-influence

Conversation

@lucaskarsten

Copy link
Copy Markdown
Contributor

Fixes #4941 .

Description of the problem being solved:

Searing Exarch and Eater of Worlds implicits can only be added to an item that has the matching influence (the Add Implicit popup only offers them when cleansing/tangle is set), but removing that influence from the influence dropdowns left the {exarch}/{eater} implicits on the item, so they kept counting in the calculations.

setDisplayItemInfluence in ItemsTab.lua only reset and re-set the influence flags. It now also removes the implicits tagged {exarch} when the item no longer has the Searing Exarch influence, and those tagged {eater} when it no longer has the Eater of Worlds influence. Other implicits are kept, and loading or selecting an item does not go through this path (the dropdowns are set without calling it), so existing items are not changed until the user edits their influence.

Steps taken to verify a working solution:

  • Added TestItemEldritchInfluence_spec.lua with a helmet that has Searing Exarch and Eater of Worlds influence, one implicit of each and a normal implicit:
    • Removing Searing Exarch from the first dropdown removes only the {exarch} implicit.
    • Removing Eater of Worlds from the second dropdown removes only the {eater} implicit.
    • Loading the item keeps both eldritch implicits.
    • Replacing Eater of Worlds with Shaper keeps the {exarch} implicit and removes the {eater} one.
  • On dev the three tests fail (1 success, the load test, / 3 failures); on this branch 4 / 0.
  • Full busted suite: 749 successes, 0 failures.

Link to a build that showcases this PR:

Any build: create a rare helmet, give it Searing Exarch influence, add a Searing Exarch implicit, then set the influence back to "Influence".

Before screenshot:

The Searing Exarch implicit stays on the helmet after the influence is removed.

After screenshot:

The Searing Exarch implicit is removed together with the influence.

Removing Searing Exarch or Eater of Worlds influence from the influence
dropdowns left the {exarch}/{eater} implicits on the item. They now get
removed together with their influence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eldritch Implicit Mods not removed when influence is removed

1 participant