Repository navigation
Fix eldritch implicits not removed when their influence is removed - #10513
Open
lucaskarsten wants to merge 1 commit into
Open
lucaskarsten wants to merge 1 commit into
lucaskarsten wants to merge 1 commit into
Conversation
Removing Searing Exarch or Eater of Worlds influence from the influence
dropdowns left the {exarch}/{eater} implicits on the item. They now get
removed together with their influence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4941 .
Description of the problem being solved:
Searing Exarch and Eater of Worlds implicits can only be added to an item that has the matching influence (the Add Implicit popup only offers them when
cleansing/tangleis set), but removing that influence from the influence dropdowns left the{exarch}/{eater}implicits on the item, so they kept counting in the calculations.setDisplayItemInfluenceinItemsTab.luaonly reset and re-set the influence flags. It now also removes the implicits tagged{exarch}when the item no longer has the Searing Exarch influence, and those tagged{eater}when it no longer has the Eater of Worlds influence. Other implicits are kept, and loading or selecting an item does not go through this path (the dropdowns are set without calling it), so existing items are not changed until the user edits their influence.Steps taken to verify a working solution:
TestItemEldritchInfluence_spec.luawith a helmet that has Searing Exarch and Eater of Worlds influence, one implicit of each and a normal implicit:{exarch}implicit.{eater}implicit.{exarch}implicit and removes the{eater}one.devthe three tests fail (1 success, the load test, / 3 failures); on this branch 4 / 0.Link to a build that showcases this PR:
Any build: create a rare helmet, give it Searing Exarch influence, add a Searing Exarch implicit, then set the influence back to "Influence".
Before screenshot:
The Searing Exarch implicit stays on the helmet after the influence is removed.
After screenshot:
The Searing Exarch implicit is removed together with the influence.