Repository navigation
Conversation
Contributor
Author
|
e500344 now has a merc import button:
But as seen in the screeenshot, I don't have a Luminary. I've tested this with some merc json examples. The PoE API should work the same |
Contributor
Author
vaisest
marked this pull request as ready for review
November 19, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description of the problem being solved:
This PR attempts to implement Mercenaries by representing them as a pseudo-minion. They are basically treated as fancy animate guardians that aren't minions. They use the mercenary gems via a toggle on the skills tab. These are added as skill parts to the Luminary granted skill "Order: To me!". This skill also has an item set selector similar to how Animate Guardians work.
The skill and support implementations are mostly done by inheriting from existing player implementations. This might result in incorrect implementations on some skills, but skips having to re-implement everything. These can be overridden later if this is a problem.
This should include most things necessary for calculating Mercs correctly. That is:
Caveats:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/poe1/pob/9b8c3 (kboc)
https://poe.ninja/poe1/pob/9b8c5 (static strike)
After screenshot: