Skip to content

Add Mercenary support by treating it as a minion-like actor - #10501

Open
vaisest wants to merge 5 commits into
PathOfBuildingCommunity:devfrom
vaisest:luminary-mercenaries
Open

vaisest wants to merge 5 commits into
PathOfBuildingCommunity:devfrom
vaisest:luminary-mercenaries

Conversation

@vaisest

@vaisest vaisest commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

This PR attempts to implement Mercenaries by representing them as a pseudo-minion. They are basically treated as fancy animate guardians that aren't minions. They use the mercenary gems via a toggle on the skills tab. These are added as skill parts to the Luminary granted skill "Order: To me!". This skill also has an item set selector similar to how Animate Guardians work.

The skill and support implementations are mostly done by inheriting from existing player implementations. This might result in incorrect implementations on some skills, but skips having to re-implement everything. These can be overridden later if this is a problem.

This should include most things necessary for calculating Mercs correctly. That is:

  • Minion modifiers from the minion code path are restricted to actual minions.
  • Auras from the player work.
  • Mercenary tuning knobs are somewhat taken into account. The ones that are known are for sure correct, but there are some that are not known by the playerbase, such as the damage taken multiplier. The attack damage multiplier IS included at up to 100%, but I don't know if it's even close to being correct. This needs some additional in-game testing somehow. The new resistance penalty is also included.
  • Merc build stats are calculated. There is a config selector for the merc build. Lower level mercs should have correct level scaling based on both the build and known penalties.
  • Links should function and so should the light radius node for it.
  • Blocked uniques are exported and blocked. The unique nodes work too.
  • Anoints work.
  • Merc configs use the minion config options. For example, "Linked to Minion?". This may or may not be confusing.
  • Merc buffs should correctly apply to the player, even when not using the granted skill.
  • Calc tab should show merc stats properly. Though given the lack of the damage intake multiplier, defensive stats might not be correct.

Caveats:

  • Mercs have rotations. This is NOT simulated here. This PR will not be able to figure out e.g. what extra skills on mercs brick them. The cooldowns, however, are exported on skills and work properly, so this could possible be done in the future?
  • It will be annoying to skip minion-specific stuff for mercs in the future.
  • The compare tab probably isn't fit for comparing merc (or AG) item sets. In general stat differences will also probably not work properly when comparing merc gear.

Steps taken to verify a working solution:

Link to a build that showcases this PR:

https://poe.ninja/poe1/pob/9b8c3 (kboc)

https://poe.ninja/poe1/pob/9b8c5 (static strike)

After screenshot:

image image image

@vaisest

vaisest commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

e500344 now has a merc import button:

image image

But as seen in the screeenshot, I don't have a Luminary. I've tested this with some merc json examples. The PoE API should work the same

@vaisest

vaisest commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

Warning labels are also now present. There's one for no build selected, and one for a build selected that can't have the current skills.

image image

@vaisest
vaisest marked this pull request as ready for review November 19, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant