Repository navigation
Fix sort function for enchants (and other paths) on offhand not working, and bug with 'remove enchant' - #10475
Merged
Wires77 merged 1 commit intoNov 17, 2026
Conversation
Wires77
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Sorting modifiers for an offhand weapon doesn't work in many cases because we evaluate it in the main hand slot instead. In a Dual Strike of Ambidexterity build, this gives every enchantment a zero Hit DPS score, effectively breaking sorting.
The affected paths found and fixed are:
The fix uses the slot where the item is actually equipped, taking the selected item set and weapon set into account. Unequipped items retain the primary slot fallback.
Enchantment and modifier previews now use the same equipment slot as sorting, so the displayed stat changes match the ranking.
Separately: Currently the enchantment modal's
Removebutton only removes one modifier line, so Harvest enchants require twoRemoveactions. This fixes thatSteps taken to verify a working solution:
Link to a build that showcases this PR:
https://pob.codes/b/yVV5dQ0qD60