Repository navigation
Update uniques from 3.30 patch notes - #10438
Merged
Wires77 merged 4 commits intoNov 15, 2026
Merged
Conversation
Add Pre 3.30.0 variants for Steelworm, Malachai's Loop, Shavronne's Wrappings, The Hallowed Monarch and Shadowstitch, and a Pre 3.30.0 version for Rotmother's Mutiny. Mods that are new this patch are kept as text in the export files until their mod IDs are available.
Contributor
|
I compared all of the items and the variants they look right, except Steelworm which has been broken for some time. The ModParser expects a value of 12 shards, and it was changed to 8 shards in 3.26 but never updated in PoB. I'm adding a pre 3.26 variant, and fixing the ModParser to also accept the 8 shard version, which makes the modifier valid. |
Steelworm's threshold changed from 12 to 8 Steel Shards in 3.26, but ModParser only matched the 12 shard wording, so the mod never applied. Parse the 8 shard version with its own config condition and add a Pre 3.26.0 variant that keeps the 12 shard wording. Co-authored-by: AdamZ-8113 <45578715+AdamZ-8113@users.noreply.github.com>
Contributor
Author
|
@AdamZ-8113 thanks! committed the patch with your credit, on top of your diff also removed the now unused nil lines from the modcache |
urbanvcode
added a commit
to urbanvcode/pob-agent-edition-pob
that referenced
this pull request
Nov 13, 2026
Temporary until an official PoB release ships the 3.30 unique changes. Taken from PathOfBuildingCommunity/PathOfBuilding#10438 by Can Uysal (with AdamZ-8113), unmerged at the time: - Data/Uniques: Pre 3.30.0 variants for Steelworm, Malachai's Loop, Shavronne's Wrappings, The Hallowed Monarch, Shadowstitch and a Pre 3.30.0 version for Rotmother's Mutiny (adbdc74) - Steelworm: 8 Steel Shards wording parsed with its own config condition, Pre 3.26.0 variant keeps the 12 shard wording (855d0f8) - ModCache: only the lines the PR adds or removes, applied to 2.67.2's cache; spec test for Steelworm Not taken: src/Export/Uniques (exporter input, not loaded by PoB; it conflicts with mod id renames on dev that 2.67.2 does not have). Kept 2.67.2's "Requires" line on The Hallowed Monarch. tools/update-pob.ps1 drops this commit automatically when the new official release contains the text below in that file. [upstream-preview: src/Data/Uniques/body.lua contains "Pre 3.30.0"] Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jclfocused
added a commit
to LaserFocused-ee/PathOfBuilding
that referenced
this pull request
Nov 14, 2026
Hand-merged from PathOfBuildingCommunity#10438 (read-only fetch). The generated unique lists for Rotmother's Mutiny, The Hallowed Monarch, Malachai's Loop, Shavronne's Wrappings and the corrupted-item body armour conflicted with the merged 3.30 export, which carried the current values without the older variants; the PR's versioned lines are taken (their headers merged cleanly and their current values match the export). ModCache regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Wires77
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Updates six uniques with their changes from the official 3.30 patch notes. Each item keeps its previous values in a
Pre 3.30.0variant, or aPre 3.30.0version for Rotmother's Mutiny.Both
src/Data/Uniquesandsrc/Export/Uniquesare updated:LightRadiusUnique__11[50,50].Version:for the patch history and{group:1}on the Fire/Cold/Lightning lines, as in Add new 3.29 Uniques #10105 and Update Replica Dragonfang's Flight to use versions and variants #10364. The element variants keep their existing numbering.Steps taken to verify a working solution:
-(6-4)%as[-6,-4].TestRareLike_spec.lua.Risks/notes
check_modcachejob currently doesn't regenerate the file: with itsLUA_PATH, HeadlessWrapper fails onrequire("Data.PearlSupports")and exits 0.Before screenshot:
After screenshot: