Repository navigation
Conversation
mcagnion
reviewed
Nov 10, 2026
| local control = self.varControls[varData.var] | ||
| if control then | ||
| local value = varData.placeholderStat and output[varData.placeholderStat] or env.configDefaults[varData.var] or values[varData.var] | ||
| control:SetPlaceholder(type(value) == "number" and string.format("%g", value) or "", false) |
Contributor
There was a problem hiding this comment.
[P2] Displayed configuration value differs from the value used
With a saved Rage placeholder of 5, the base displays 5, while this PR displays the calculated maximum of 30. The calculation still uses the saved value of 5. The Configuration tab therefore shows a different value from the one actually used.
AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused base/HEAD UI reproduction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Contains a bunch of improvements to the Configuration menu:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/yjk3HybFSd3W
Before screenshot:
After screenshot:
Default config of a new build now:

New Attached Brand duration mode dropdown:
