Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This was originally meant to improve performance after I noticed that LuaJIT traces sometimes fail in the big
if ... elseblock in modifier tag evaluation. I observed as much as 1.5-2x speedups with some builds.However, LuaJIT tracing is inconsistent and nondeterministic. With the same commit and build, I now see no measurable change in performance.
Despite this I believe this change is still beneficial because it improves readability and documentation. I aimed to preserve the existing behavior where possible, while tightening constraints and making them more explicit.
Steps taken to verify a working solution:
Strictly speaking, some actor variables change from
falsetonilbut this does not result in any logic change.I understand that despite finding no bugs in testing this situation is a bit peculiar because the very core of the calculations is being modified. On one hand the code is executed a lot, so any error should surface quickly, on the other hand the potential surface area is enormous.