Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328.
Description of the problem being solved:
From what I can see, PoB2's leech is just based on PoE1 mechanics, which doesn't really seem sensible when PoE2 leech is entirely different. This PR removes a bunch of PoE1-only code and mods, and implements a version of leech that is more like ailment calculations, which are very similar to how leech works. The damage is also capped to 40k here and leech resistances are exported and used.
This is rather clanker-driven (especially the breakdowns), but I feel like this is a more correct direction than incorrectly using PoE1 mechanics. This also intentionally only has the minimum amount of mechanics and mods for PoE2
Steps taken to verify a working solution:
Link to a build that showcases this PR:
After screenshot: