Repository navigation
Conversation
A skill whose effect hits every N seconds got HitSpeed = 1 / N regardless of how often it is used, so a cooldown support such as Hourglass made PoB count hits for the whole cooldown (Firestorm + Hourglass: 50.2 hits per cast for a 6 s storm). Cap HitSpeed at Speed * Duration / HitTime when the duration is known, in both places hitTimeOverride is applied. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a skill whose damage comes from an effect that hits every N seconds (
skillData.hitTimeOverride: Firestorm, Thunderstorm, Icestorm, Galvanic Field, Solar Orb, Storm Lance's lodged spear, Elemental Storm, a per-enemy hit limit, ...),CalcOffencesetsin two places: the per-pass block and the attack block after the passes are combined.
TotalDPSis thenAverageDamage * HitSpeed * DpsMultiplier. The use rate (Speed) never enters, so the calculation assumes one effect is up all the time.That holds while the skill is cast at least once per effect duration. It fails when the skill is used less often than its effect lasts. The clearest case is a cooldown support such as Hourglass ("Supported Skills have a Cooldown of 10 seconds", 30% more damage). Example: Firestorm 20 with Hourglass.
Speedis 0.0997/s (one cast per ~10 s),Durationis 6.0 s, and there is one impact every 0.2 s.HitSpeed= 5/s, i.e. 50.2 hits per cast for a storm that can hit at most 30 times.The other branch (
hitTimeMultiplier) already accounts for a cooldown (1 / (HitTime + Cooldown)); only the override branch does not.Change
After
HitSpeed = 1 / HitTime, in both places, cap the hit rate at the effect's uptime when the skill's duration is known:The following are unchanged:
Speed * Duration >= 1);hitTimeOverrideis the time to gather the seals, not a hit interval.Tests
Two specs are added in
spec/System/TestOffence_spec.lua:HitSpeed == Speed * Duration / HitTime. This spec fails ondevwithout the change.HitSpeed == 1 / HitTime, unchanged.Full suite in the
pathofbuilding-testsimage: 905 successes / 0 failures (devwithout the change: 903 / 0).Open point (not addressed here)
Ball Lightning's projectile has no duration in the skill data. Its stat sets give the hit frequency; the 4 s in its third stat set belongs to the Ignited Ground. With Hourglass it shows the same 50.2 hits per cast. How long one ball keeps hitting a target depends on projectile speed and range, which PoB does not model, so this change leaves it as is.
This is a separate bug from #2588 (conversion order); the two PRs are independent.
🤖 Generated with Claude Code