Fix gem level behaviour of support granted skills - #2521
Open
vaisest wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This fixes an issue reported on Reddit where Chaos Mastery linked with Despair and Doedre's Undoing doesn't increase damage. This seems to have been caused by the support granted skill code only copying the base parent gem level, which doesn't include e.g. support gem or item +levels.
The calc tab also assumed level 1 on the gem.
Now, the gem level is just from another active skill, and the calc tab shows that level while hiding modifiers.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/poe2/pob/28c7b
Before screenshot:
After screenshot: