Add support for Runeforged/mastered unique variants - #2511
Merged
LocalIdentity merged 2 commits intoSep 10, 2026
Conversation
vaisest
marked this pull request as draft
September 8, 2026 09:21
vaisest
force-pushed
the
item-db-runeforging
branch
from
September 9, 2026 16:01
610c432 to
c175339
Compare
vaisest
marked this pull request as ready for review
September 9, 2026 16:03
Mods were not checking if the base and variant matched and were just applying all the mods for a particular base
LocalIdentity
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This adds support for runeforged/mastered base variants in the unique DB. This does not change the default behaviour as an item due to e.g. the level requirements using the unique DB. I'm also not really sure defaulting to the best variant is desired since I'm not sure how exactly people use the item DB.
This is done by adding a new tag which works similarly to variants, but is treated as its own group, similar to what has been done with unique versions:
This should also work with versioning, if that is even necessary:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: