Skip to content

Add support for increased mod magnitude mods and Unborn Lich#2375

Open
vaisest wants to merge 5 commits into
PathOfBuildingCommunity:devfrom
vaisest:advanced-mod-scaling
Open

Add support for increased mod magnitude mods and Unborn Lich#2375
vaisest wants to merge 5 commits into
PathOfBuildingCommunity:devfrom
vaisest:advanced-mod-scaling

Conversation

@vaisest

@vaisest vaisest commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Fixes #2216, fixes #2300

Description of the problem being solved:

This solves:

  • Catalysts applying to Item:BuildRaw() texts. The exported text is supposed to represent the base mod, and this resulted in repeated additions of mod values.
  • Mod magnitude mods not being supported. This became relevant when advanced mod support was added.
  • Other mod effect mods such as jewels and experimented rings

Steps taken to verify a working solution:

  • former tests pass
  • items render correctly when manually tested
  • automated tests were added
  • Also seemed to work in pob1

Link to a build that showcases this PR:

Item Class: Quarterstaves
Rarity: Rare
Cataclysm Branch
Dreaming Quarterstaff
--------
Quality: +23% (augmented)
Physical Damage: 838-1 270 (augmented)
Critical Hit Chance: 0.00%
Attacks per Second: 1.90 (augmented)
--------
Requires: Level 78, 127 Dex, 50 Int
--------
Sockets: S S S 
--------
Item Level: 82
--------
40% increased Physical Damage (rune)
Can roll Destruction modifiers (rune)
--------
{ Fractured Prefix Modifier "Merciless" (Tier: 1) — Damage, Physical, Attack — 15% Increased }
179(170-179)% increased Physical Damage
{ Prefix Modifier "Flaring" (Tier: 1) — Damage, Physical, Attack — 15% Increased }
Adds 51(37-55) to 92(63-94) Physical Damage
{ Desecrated Prefix Modifier "Dictator's" (Tier: 1) — Damage, Physical, Attack — 15% Increased }
78(75-79)% increased Physical Damage
+198(175-200) to Accuracy Rating
{ Suffix Modifier "of War" (Tier: 1) — Attack }
+5 to Level of all Melee Skills
{ Suffix Modifier "of Celebration" (Tier: 1) — Attack, Speed }
27(26-28)% increased Attack Speed
{ Suffix Modifier "of Destruction" (Tier: 1) — Physical — 15% Increased }
15(10-15)% increased Explicit Physical Modifier magnitudes — Unscalable Value
--------
Fractured Item
--------
Note: ~b/o 2 mirror
Item Class: Bows
Rarity: Rare
Glyph Fletch
Obliterator Bow
--------
Quality: +30% (augmented)
Physical Damage: 558-1 021 (augmented)
Critical Hit Chance: 10.17% (augmented)
Attacks per Second: 1.86 (augmented)
--------
Requires: Level 78, 163 Dex
--------
Sockets: S S S 
--------
Item Level: 82
--------
+1 Suffix Modifier allowed (rune)
50% increased Attack Speed (rune)
20% less Attack Damage (rune)
Can roll Destruction modifiers (rune)
--------
{ Implicit Modifier }
52(50)% reduced Projectile Range
--------
{ Prefix Modifier "Merciless" (Tier: 1) — Damage, Physical, Attack — 14% Increased }
178(170-179)% increased Physical Damage
{ Prefix Modifier "Dictator's" (Tier: 1) — Damage, Physical, Attack — 14% Increased }
91(75-79)% increased Physical Damage
+210(175-200) to Accuracy Rating
{ Prefix Modifier "Flaring" (Tier: 1) — Damage, Physical, Attack — 14% Increased }
Adds 39(26-39) to 70(44-66) Physical Damage
{ Fractured Suffix Modifier "of Acclaim" (Tier: 1) — Attack, Speed }
19(17-19)% increased Attack Speed
{ Suffix Modifier "of the Sniper" (Tier: 1) }
+5(4) to Level of all Projectile Skills
{ Suffix Modifier "of Unmaking" (Tier: 1) — Attack, Critical }
+5.17(4.41-5)% to Critical Hit Chance
{ Desecrated Suffix Modifier "of Destruction" (Tier: 1) — Physical — 14% Increased }
14(10-15)% increased Explicit Physical Modifier magnitudes — Unscalable Value
--------
Sanctified
--------
Fractured Item
--------
Note: ~b/o 8 mirror

Copy paste twice to work around paste issues (unrelated to this PR)

Item Class: Jewels
Rarity: Rare
Pandemonium Desire
Sapphire
--------
Quality (Caster Modifiers): +20% (augmented)
--------
Item Level: 80
--------
{ Corruption Enhancement — Elemental, Cold, Resistance }
+7(5-10)% to Cold Resistance
{ Corruption Enhancement — Attribute }
+6(4-6) to Intelligence
--------
{ Fractured Crafted Prefix Modifier "" }
60(40-60)% increased Effect of Suffixes — Unscalable Value
{ Prefix Modifier "Mystic" (Tier: 1) — Damage, Caster — 20% Increased }
7(5-15)% increased Spell Damage
{ Suffix Modifier "of Unmaking" (Tier: 1) — Damage, Caster, Critical — 80% Increased }
20(10-20)% increased Critical Spell Damage Bonus
{ Desecrated Suffix Modifier "of Annihilating" (Tier: 1) — Caster, Critical — 80% Increased }
15(5-15)% increased Critical Hit Chance for Spells
{ Suffix Modifier "of Potency" (Tier: 1) — Damage, Critical — 60% Increased }
20(10-20)% increased Critical Damage Bonus
--------
Place into an allocated Jewel Socket on the Passive Skill Tree. Right click to remove from the Socket.
--------
Twice Corrupted
--------
Fractured Item
--------
Note: ~b/o 3000 mirror

Before screenshot:

image image

After screenshot:

image image
Path.space.of.space.Building-PoE2_2026-07-13_21-47-40.mp4

@vaisest vaisest marked this pull request as draft July 13, 2026 19:24
@vaisest vaisest force-pushed the advanced-mod-scaling branch from 09170ad to ff39c3a Compare July 14, 2026 16:35
@vaisest vaisest marked this pull request as ready for review July 14, 2026 16:49
@vaisest vaisest force-pushed the advanced-mod-scaling branch from 9fa5a25 to 2c3b476 Compare July 14, 2026 17:51
@vaisest vaisest force-pushed the advanced-mod-scaling branch from 06883a9 to e33f3d2 Compare July 14, 2026 18:43
Comment thread src/Classes/ItemsTab.lua
end)
self.controls.displayItemCatalyst.shown = function()
return self.displayItem and (self.displayItem.crafted or self.displayItem.hasModTags) and (self.displayItem.base.type == "Amulet" or self.displayItem.base.type == "Ring")
return self.displayItem and (self.displayItem.crafted or self.displayItem.hasModTags) and (self.displayItem.base.type == "Amulet" or self.displayItem.base.type == "Ring" or self.displayItem.base.type == "Jewel")

@vaisest vaisest Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also enabled the catalyst menu for jewels. This is slightly unrelated to this PR, but catalysts didn't seem to have any problems with jewels during the making of this PR, so this seems like a safe change. The catalyst lists are the same for both jewellery and jewels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing emotion and ancient emotion modifiers for jewels and time-lost jewels Item from market adds in PoB2 with wrong stats.

1 participant