Removes RetryHistory.Id - #5698
Merged
Merged
Conversation
This is just a Raven concern
warwickschroeder
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RavenDB store now passes the document key to
StoreAsyncexplicitly rather than stamping it onto the model.Why
The property only ever held the constant
"RetryOperations/History", the key of the singleton document the retry history lives in.4966cf21c3("move all ravendb specific ID generation into the ravenDB persistence layer") already deletedRetryHistory.MakeId()and inlined the string as a private const in the Raven store. TheIdproperty was the last piece left behind, and it leaks a document-store concept into a model that the EF Core persisters also have to implement, where there is no document and no key to carry.Impact
GET /api/recoverability/historyno longer returnsid.This PR against ServicePulse ensures we are not using the Id on the frontend code.