Skip to content

PPR-26: Book import workflow rework - #22

Open
Eoic wants to merge 19 commits into
masterfrom
feature/PPR-26-book-imports-rework
Open

PPR-26: Book import workflow rework#22
Eoic wants to merge 19 commits into
masterfrom
feature/PPR-26-book-imports-rework

Conversation

@Eoic

@Eoic Eoic commented Aug 1, 2026

Copy link
Copy Markdown
Member

Ticket

<Trello card link>

Summary

Describe the problem, what changed, and why this approach was chosen.

Testing

Describe the testing steps so that reviewers can follow them step-by-step and test the introduced changes.

UI evidence

Add screenshots or recordings, or write - if not applicable.

Compatibility and migration

Describe breaking changes and migrations, or write - if not applicable.

Notes

Add reviewer guidance, risks, or follow-up tasks, if any.

Checklist

  • The branch, commits, and pull request title follow the repository conventions.
  • The change is complete and limited to the ticket's scope.
  • Relevant tests have been added or updated.
  • Formatting, analysis, and tests pass.
  • Documentation, UI evidence, and migration notes are included where relevant.
  • No credentials, personal data, copyrighted fixtures, or unrelated generated files are included.
  • The branch is up to date with its target branch.

Copilot AI review requested due to automatic review settings August 1, 2026 20:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a design/spec document describing a reworked book import workflow, separating digital/physical import into distinct bottom sheets and introducing a multi-file digital import flow with a results/commit step.

Changes:

  • Documented new bottom-sheet structure (AddBookSheetScaffold) to standardize fixed header/body/footer layout across add-book flows.
  • Specified a multi-file digital import selection sheet (DigitalBookImportSheet) and a processing/commit results sheet (BookImportResultsSheet) with retry/removal and cleanup rules.
  • Outlined verification coverage expectations (widget/model tests) and operational assumptions for the workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


- Removing a ready row deletes the temporary imported book file created by `BookImportService`.
- Retrying metadata processing starts from the original bytes; retrying a commit reuses its existing parsed result and temporary file.
- Cancelling, closing, or dismissing the results sheet deletes every successful-but-uncommitted temporary file.
@Eoic Eoic self-assigned this Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants