Skip to content

[ci skip] Correct MOB_GRIEFING javadoc on explode events - #14195

Open
CJH3139 wants to merge 2 commits into
PaperMC:mainfrom
CJH3139:fix/13428-explode-event-mob-griefing-javadoc
Open

[ci skip] Correct MOB_GRIEFING javadoc on explode events#14195
CJH3139 wants to merge 2 commits into
PaperMC:mainfrom
CJH3139:fix/13428-explode-event-mob-griefing-javadoc

Conversation

@CJH3139

@CJH3139 CJH3139 commented Aug 18, 2026

Copy link
Copy Markdown

Small change to javadoc clarifying wind charge cases in EntityExplodeEvent.
Also removed the MOB_GRIEFING comment from BlockExplodeEvent as it was misleading

Closes #13428

@CJH3139
CJH3139 requested a review from a team as a code owner August 18, 2026 02:17
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Aug 18, 2026
Comment thread paper-api/src/main/java/org/bukkit/event/entity/EntityExplodeEvent.java Outdated
…vent.java

Co-authored-by: Nassim Jahnke <nassim@njahnke.dev>
@CJH3139
CJH3139 requested a review from kennytv August 19, 2026 22:41
Comment on lines +16 to +18
* Explosions caused by mobs do not interact with blocks
* while {@link org.bukkit.GameRules#MOB_GRIEFING} is disabled
* as no block interaction will occur. That game rule does not

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should still say that explosions caused by mobs don't call the event, what's currently written reads bit weirdly since it says no block interactions will occur twice without saying anything about whether it's still called or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

EntityExplodeEvent javadoc confusing in wind charge cases

3 participants