Skip to content

🪲 [Fix]: Plan no longer fails on schedule/workflow_dispatch (skip version resolution on non-PR events) #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marius Storhaug (MariusStorhaug) wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −1
Open

🪲 [Fix]: Plan no longer fails on schedule/workflow_dispatch (skip version resolution on non-PR events) #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fad8822
Skip version resolution on non-PR events so schedule/dispatch runs do…
MariusStorhaug Jul 10, 2026
7a5a176
Fall back to 999.0.0 placeholder for module-local test import on non-…
MariusStorhaug Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/Plan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ jobs:
ImportantFilePatterns: ${{ inputs.ImportantFilePatterns }}

- name: Resolve-Version
# Version resolution requires pull_request context (PR labels + head ref decide the
# bump and the prerelease name). Skip it on non-PR events (schedule, workflow_dispatch,
# push): there ReleaseType is 'None', nothing is published, and Enrich-Settings falls
# back to safe empty defaults. Without this gate the action throws on non-PR events and
# fails the whole run. Fixes #373.
if: github.event_name == 'pull_request'
Comment on lines +89 to +93
uses: PSModule/Resolve-PSModuleVersion@d53326c7687d20a7949d457fccd71223856b1890 # v1.1.0
id: Resolve-Version
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Test-ModuleLocal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,4 @@ jobs:
WorkingDirectory: ${{ fromJson(inputs.Settings).WorkingDirectory }}
Prescript: | # This is to speed up module loading in Pester.
Install-PSResource -Repository PSGallery -TrustRepository -Name PSCustomObject
Import-Module -Name '${{ steps.import-module.outputs.name }}' -RequiredVersion '${{ fromJson(inputs.Settings).Module.Version }}'
Import-Module -Name '${{ steps.import-module.outputs.name }}' -RequiredVersion '${{ fromJson(inputs.Settings).Module.Version != '' && fromJson(inputs.Settings).Module.Version || '999.0.0' }}'
Loading