Skip to content

Added van id to tables - #182

Merged
SauravBizbRolly merged 2 commits into
release-3.8.3from
van
Aug 6, 2026
Merged

Added van id to tables#182
SauravBizbRolly merged 2 commits into
release-3.8.3from
van

Conversation

@vishwab1

@vishwab1 vishwab1 commented Aug 6, 2026

Copy link
Copy Markdown
Member

📋 Description

JIRA ID:

Please provide a summary of the change and the motivation behind it. Include relevant context and details.


✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

vishwab1 and others added 2 commits August 6, 2026 15:20
…rce.vanid config

- IdentityService.createIdentity(): previously had zero enforce-vanid
  check at all (only RmnchDataSyncServiceImpl had it) - now throws if
  vanID is missing and enforceVanID=true, matching the convention
  everywhere else
- Remove inline :false default from stoptb.enforce.vanid @value in both
  IdentityService and RmnchDataSyncServiceImpl - every properties file
  must set this explicitly now, so a forgotten config fails loudly at
  startup instead of running fail-open
- Add stoptb.enforce.vanid=false to the 1097_* profile properties
  (separate Maven build sharing these same classes, not a van
  deployment, so stays false, but must be explicit)

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1313b7c6-8386-4455-bb29-9c0c5bd84714

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

@SauravBizbRolly
SauravBizbRolly merged commit 66d3d0f into release-3.8.3 Aug 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants