Skip to content

Add silu support, fix neural_nets typo - #90

Open
dilpath wants to merge 2 commits into
mainfrom
silu_and_typo_neural_nets
Open

Add silu support, fix neural_nets typo#90
dilpath wants to merge 2 commits into
mainfrom
silu_and_typo_neural_nets

Conversation

@dilpath

@dilpath dilpath commented Jul 22, 2026

Copy link
Copy Markdown
Member

The Dandekar problem uses the SiLU activation function, which is currently not in the documented list of supported functions.
https://github.com/sebapersson/Benchmark-Models-PEtab-SciML/blob/8fcc885dd3599fa1c536a7084993a7a522df343c/Benchmark-Models/Dandekar_Patterns2020/net1_Dandekar_Patterns2020.yaml#L31

@dilpath
dilpath requested review from BSnelling and sebapersson and removed request for sebapersson July 22, 2026 12:49

@sebapersson sebapersson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, forgot this.

silu is at least supported in the test-suite, see PEtab-dev/petab_sciml_testsuite#36

Comment thread doc/layers.rst Outdated
| moid <https://pytorch.org/docs/stable/generated/torch.nn.fun | | |
| ctional.hardsigmoid.html#torch.nn.functional.hardsigmoid>`__ | | |
+--------------------------------------------------------------+----+---+
| `silu <https://pytorch.org/docs/stable/generated/torch.nn | ✔️ | |

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you here highlight this activation function is also called swish, e.g., silu (swish), as it is called swish in Lux.jl?

@dilpath
dilpath requested a review from sebapersson July 23, 2026 17:09
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.13%. Comparing base (2ef0387) to head (70551c6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   94.01%   95.13%   +1.11%     
==========================================
  Files           6        7       +1     
  Lines         301      370      +69     
==========================================
+ Hits          283      352      +69     
  Misses         18       18              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants