Add silu support, fix neural_nets typo - #90
Open
dilpath wants to merge 2 commits into
Open
Conversation
dilpath
requested review from
BSnelling and
sebapersson
and removed request for
sebapersson
July 22, 2026 12:49
sebapersson
requested changes
Jul 23, 2026
sebapersson
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, forgot this.
silu is at least supported in the test-suite, see PEtab-dev/petab_sciml_testsuite#36
| | moid <https://pytorch.org/docs/stable/generated/torch.nn.fun | | | | ||
| | ctional.hardsigmoid.html#torch.nn.functional.hardsigmoid>`__ | | | | ||
| +--------------------------------------------------------------+----+---+ | ||
| | `silu <https://pytorch.org/docs/stable/generated/torch.nn | ✔️ | | |
Collaborator
There was a problem hiding this comment.
Could you here highlight this activation function is also called swish, e.g., silu (swish), as it is called swish in Lux.jl?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 94.01% 95.13% +1.11%
==========================================
Files 6 7 +1
Lines 301 370 +69
==========================================
+ Hits 283 352 +69
Misses 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dandekar problem uses the SiLU activation function, which is currently not in the documented list of supported functions.
https://github.com/sebapersson/Benchmark-Models-PEtab-SciML/blob/8fcc885dd3599fa1c536a7084993a7a522df343c/Benchmark-Models/Dandekar_Patterns2020/net1_Dandekar_Patterns2020.yaml#L31