Repository navigation
Conversation
Restore the accelerated leading iterator's saved start before a non-advancing control-verb reset. Otherwise the next bumpalong can skip a valid start after a lazy repeat, leaving JIT inconsistent with the interpreter under end anchoring. Add THEN/PRUNE regressions and SKIP/COMMIT controls in testinput2. Fixes PCRE2Project#359 Assisted-by: OpenAI Codex Reviewed-by: GPT-6 Luna (AI)
Collaborator
|
Is this pattern is the same as |
Contributor
Author
|
For Checked at all three widths. Literal |
Collaborator
|
See #1039 The issue is theoretical, |
Member
|
@zherczeg, I leave this ticket to you to discuss or close. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/a+?(*THEN)/endanchoredmissesaaaain JIT, while the interpreter matches the finala. A control verb leaves the accelerated retry cursor one character ahead; restore it before bumpalong.Adds regressions for
THEN,PRUNE,SKIP, andCOMMIT. New cases fail before the fix across 8/16/32-bit JIT; full CTest passes (4/4).Fixes #359.
I’ve reviewed the code.