Fix lost key/mouse events and scroll accumulation within a frame (#847) - #854
Merged
adriengivry merged 3 commits intoSep 20, 2026
Merged
Conversation
adriengivry
requested changes
Sep 19, 2026
adriengivry
reviewed
Sep 20, 2026
adriengivry
reviewed
Sep 20, 2026
adriengivry
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the input handling bug reported in #847, where clicks, key presses, and mouse wheel notches get lost within a single frame.
Changes
-- Replaced single state event maps in InputManager with separate per-frame flag maps (m_keyPressed, m_keyReleased, m_mouseButtonPressed, m_mouseButtonReleased).
-- Changed OnMouseScroll to accumulate deltas (+=) instead of overwriting.
-- Updated ClearEvents() to reset scroll vector and clear frame flags.
-- Kept public API signature unchanged.
Related Issue(s)
Fixes #847
Review Guidance
Main changes are in InputManager.cpp / .h.
ClearEvents() logic remains tied to the end-of-frame tick,
How to test
Left button downandLeft button up.Screenshots/GIFs
none!
AI Usage Disclosure
none!
Checklist