Prefer full-res image if the full-res image is smaller - #1
Closed
TTtie wants to merge 1 commit into
Closed
Conversation
TTtie
force-pushed
the
tttie/fix/prefer-smaller-images
branch
from
August 25, 2026 16:26
cac3f2a to
7c01d37
Compare
Member
Author
|
some changes have happened and this isn't needed anymore 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, the rendered small thumbnail can end up being larger than the full-res image, and in the worst case, the thumbnail can end up being 5 times as large as the original file. For example, https://github.com/OvercastCommunity/CommunityMaps/tree/27d0cd6d82cba386d07ed5a47ebd864db25b9c11/mixed/trial_chambers full-res image ends up at 8 KiB, while the thumbnail expands to 37-38 KiB depending on the render direction.
This PR makes it so the smaller of the two is preferred. For the time being, this is a draft that discards the thumbnail when it is larger, but we might want to look into throwing the thumbnail away if it ends yielding not much benefit in size over the full-res image.