Exit quietly when the reader closes stdout - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sqlx sql execute … | head -c 100panicked withthread 'main' panicked at …/stdio.rs:1165: failed printing to stdout: Broken pipeon stderr and exit code 101, because the result and error paths print withprintln!, which panics when the write fails.Both paths now go through one helper:
BrokenPipeexits silently with status 0 (the consumer stopped reading, which is normal forhead), any other write failure still reports itself on stderr and exits 1. The streamed event output already used fallible writes.Verification
Large Oracle result (5000 rows), stdout piped to
head -c 100:SELECT COUNT(*) … level <= 5000returns[['5000']].cargo fmt,clippy --workspace --all-targets --locked -- -D warningsandcargo test -p ottermind-sqlxpass.Risks and limits