Keep JDBC driver diagnostics out of stderr - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A failed Oracle connection wrote 55 lines to stderr, 32 of them
信息:records and stack frames from the driver's ownjava.util.loggingdiagnostics, which buries the one actionable line.JdbcWorker.mainnow resets the logging configuration before any driver loads, so vendor diagnostics stay silent;SQLX_JDBC_DEBUG=1restores them for troubleshooting. The README notes the switch.Verification
Same Oracle datasource with the default
verify-full, worker built from this branch and passed through--worker-dir:--tls disable:{"event":"connected"}andSELECT 1 AS one FROM dualreturns[['1']], 0 extra stderr lines.mvn -B -f java/jdbc/pom.xml verifypassed (2 tests).Risks and limits
SQLX_JDBC_DEBUG=1to reproduce them.LogManager.reset()also drops logging configuration a driver may install later; the drivers used here re-create what they need.