Let skill status and remove forget missing installations - #13
Merged
Merged
Conversation
openai0229
force-pushed
the
feat/skill-remove
branch
from
September 20, 2026 10:07
e5a0a96 to
7ebf09b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sqlx skill statuslisted a record forever after its directory was deleted, always asintact: false, and there was no command to drop the record — the only fix was editing~/.sqlx/skill-installs.jsonby hand.statusnow reportsmissing: truefor a record whose directory no longer exists, so "deleted" and "locally modified" are distinguishable.sqlx skill remove --path <skill-directory>drops the record. It never deletes files; the response reportsdirectory_existsso the caller knows whether anything is still on disk./tmp/...is deleted,remove --path /tmp/...still matches the recorded/private/tmp/...(this was a real failure found while testing the command).Verification
cargo fmt --all -- --check,cargo clippy --workspace --all-targets --locked -- -D warningspassed, andcargo test -p ottermind-sqlxruns three unit tests for removal, the missing flag and the deleted-directory path match.Risks and limits
removeintentionally does not delete files; removing a directory remains a user action.dsh/pitarget branch both append tocrates/cli/src/skill.rs; whichever merges second needs the test modules combined.