Repository navigation
Windows and MacOS acceptance - #195
Merged
Merged
Conversation
The options were written out in the Write .beaker.yml step of the acceptance job. The acceptance jobs for hosted runners need the same ones, so project-config.sh now puts them together and the step only adds the ssh key and the shard tag. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com> Assisted-by: Claude Fable 5.2 <noreply@anthropic.com>
nested_vms has no Windows or MacOS images, so no acceptance job tested those packages. The openvox-agent suite now also runs on GitHub-hosted runners of those systems, with the runner itself as the Beaker host. On Windows, Beaker connects over ssh to an sshd in Cygwin, because the tests' Windows branches were written for Beaker's cygwin host type. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com> Assisted-by: Claude Fable 5.2 <noreply@anthropic.com>
When sshd exits right after it starts, cygrunsrv only reports Win32 error 1062. Print sshd's log, whatever holds port 22, Windows' own sshd service and the latest Application events before failing. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com> Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
On windows-2025, Cygwin's sshd exits right after it starts. Windows Server 2025 comes with Microsoft's OpenSSH server, which holds port 22 when it runs, so stop it first. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com> Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
The folders Cygwin created under C:\ProgramData\PuppetLabs got POSIX-style ACLs, and files that only inherit those deny their owner access. Puppet then couldn't read the facts the tests copied there, or write its own state. Mount the drives with noacl, as the Cygwin build in build_vanagon.yml does. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com> Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
bastelfreak
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds running the openvox-agent suite on MacOS and Windows flavors by running them directly on the GitHub runner of that type. For Windows, we are SSHing to itself which is a little funky, but migrating tests to use the powershell method instead will take a lot more test refactoring.