Repository navigation
refactor(models): define pretrain and optimize_hparams once - #634
Open
jorisstrakeljahn wants to merge 3 commits into
Open
jorisstrakeljahn wants to merge 3 commits into
jorisstrakeljahn wants to merge 3 commits into
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pretrainandoptimize_hparamsexisted twice, almost word for word, in the classifier base and the regressor base. The only intended difference was one True or False flag. This PR moves both into a small mixin that the two bases share, so the copies cannot drift apart.They had already started to drift a little. The classifier checked for a missing data module and raised NotFittedError. The regressor had no such check, only a type ignore, and would fail with an AttributeError. Both now raise NotFittedError. A built model always has a data module, so I think this only shows if someone clears it by hand.
There are three commits:
The public methods and their signatures are unchanged. I compared main and this branch with a script: all public method signatures of the estimators are identical, and seeded runs of pretrain and of a short search give identical weights and predictions.
I left the regression argument of the search mixin alone, although nothing reads it. Removing it needs a change in
lss_base.py, which several open PRs touch.just test: 3376 passedjust check: passes