add es/fr/de/zh/hi translations by abdulsaheel · Pull Request #295 · OpenStrap/edge

abdulsaheel · 2026-08-26T18:06:14Z

User description

adds spanish, french, german, chinese simplified, hindi arbs on top of #291's picker. same 5 keys as app_en.arb, updated _kLanguageNames in profile.dart. gen-l10n + analyze clean.

Summary by Sourcery

Expand localization support with five additional languages and make them selectable from the profile language picker.

New Features:

Add Spanish, French, German, Simplified Chinese, and Hindi localization resources for the application.
Expose the five new languages in the profile language picker using native language names.

Enhancements:

Update profile-related golden test setup to provide the locale controller required by localized UI.

Tests:

Update onboarding and profile golden test infrastructure to support locale state.

PR Type

Enhancement

Description

Add five new language translations
Update profile language picker options
Note: No tests added for new behavior

Diagram Walkthrough

flowchart LR
  id1["Profile Language Picker"] -- "Displays new options" --> id2["es, fr, de, zh, hi"]
  id3["ARB Files"] -- "Provide localized strings" --> id2

File Walkthrough

Relevant files

Enhancement

profile.dart `Update language picker options` lib/ui2/profile/profile.dart Added `es`, `fr`, `de`, `zh`, and `hi` to `_kLanguageNames` Mapped language codes to their native display names	+8/-1
app_de.arb `Add German localization` lib/l10n/app_de.arb Added German translations for core app strings	+8/-0
app_es.arb `Add Spanish localization` lib/l10n/app_es.arb Added Spanish translations for core app strings	+8/-0
app_fr.arb `Add French localization` lib/l10n/app_fr.arb Added French translations for core app strings	+8/-0
app_hi.arb `Add Hindi localization` lib/l10n/app_hi.arb Added Hindi translations for core app strings	+8/-0
app_zh.arb `Add Chinese localization` lib/l10n/app_zh.arb Added Simplified Chinese translations for core app strings	+8/-0

Summary by CodeRabbit

New Features
- Added German, Spanish, French, Hindi, and Simplified Chinese translations for app titles, profile settings, device lists, and language options.
- Added localized names for supported languages in the language picker.
- Added support for selecting the device’s system-default language where available.

sourcery-ai · 2026-08-26T18:06:23Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds Spanish, French, German, Simplified Chinese, and Hindi localization resources for the existing five keys, then registers those locales in the profile language picker; localization generation and static analysis are reported clean.

Flow diagram for registering localized profile languages

flowchart LR
    ARB["app_es.arb, app_fr.arb, app_de.arb, app_zh.arb, app_hi.arb"] --> GEN[gen-l10n]
    GEN --> LOC[AppLocalizations]
    LOC --> MAP[_kLanguageNames]
    MAP --> PICKER[Profile language picker]

File-Level Changes

Change	Details	Files
Add five locale ARB files containing translations for the existing localization keys.	Add Spanish, French, German, Simplified Chinese, and Hindi translation resources. Keep each locale aligned with the five keys defined in the English source ARB.	`lib/l10n/app_es.arb` `lib/l10n/app_fr.arb` `lib/l10n/app_de.arb` `lib/l10n/app_zh.arb` `lib/l10n/app_hi.arb`
Expose the new locales through the profile language picker.	Register es, fr, de, zh, and hi with their native language display names. Rely on generated localization availability so the picker only offers locales with resources.	`lib/ui2/profile/profile.dart`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

coderabbitai · 2026-08-26T18:06:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e3112fad-9e1d-4193-ae9c-1bb761796ee2

📥 Commits

Reviewing files that changed from the base of the PR and between a3cff0b and 0874f78.

⛔ Files ignored due to path filters (1)

test/ui2_onboarding_profile_golden_test.dart is excluded by !test/**

📒 Files selected for processing (6)

lib/l10n/app_de.arb
lib/l10n/app_es.arb
lib/l10n/app_fr.arb
lib/l10n/app_hi.arb
lib/l10n/app_zh.arb
lib/ui2/profile/profile.dart

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

📝 Walkthrough

Walkthrough

Added German, Spanish, French, Hindi, and Simplified Chinese localization resources. Expanded the language picker map to display localized names for all supported locales.

Changes

Localization language support

Layer / File(s)	Summary
Locale resources `lib/l10n/app_de.arb`, `lib/l10n/app_es.arb`, `lib/l10n/app_fr.arb`, `lib/l10n/app_hi.arb`, `lib/l10n/app_zh.arb`	Added locale metadata and translated application, profile, device, language, and system-default labels.
Language picker names `lib/ui2/profile/profile.dart`	Added display names for Spanish, French, German, Chinese, and Hindi language codes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 0874f

This change adds five localized language options and updates the language picker without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding Spanish, French, German, Simplified Chinese, and Hindi translations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/i18n-5-languages

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

sourcery-ai

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

github-actions · 2026-08-26T18:07:53Z

PR Reviewer Guide 🔍

(Review updated until commit `0874f78`)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

github-actions · 2026-08-26T18:08:14Z

PR Code Suggestions ✨

No code suggestions found for the PR.

github-actions · 2026-08-26T22:06:34Z

Persistent review updated to latest commit 0874f78

github-actions · 2026-08-26T22:06:49Z

PR Code Suggestions ✨

No code suggestions found for the PR.

add es/fr/de/zh/hi translations for language picker

5b98a6d

sourcery-ai Bot approved these changes Aug 26, 2026

View reviewed changes

github-actions Bot added the Review effort 1/5 label Aug 26, 2026

fix golden test: provide LocaleController so profile screens don't throw

0874f78

abdulsaheel merged commit 9a4c4a0 into main Aug 27, 2026
3 of 4 checks passed

abdulsaheel deleted the feat/i18n-5-languages branch August 27, 2026 01:35

Navigation Menu

Uh oh!

Uh oh!

add es/fr/de/zh/hi translations - #295

add es/fr/de/zh/hi translations#295
abdulsaheel merged 2 commits into
mainfrom
feat/i18n-5-languages

abdulsaheel commented Aug 26, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

sourcery-ai Bot commented Aug 26, 2026 •

edited

Loading

Reviewer's Guide

Flow diagram for registering localized profile languages

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

coderabbitai Bot commented Aug 26, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

github-actions Bot commented Aug 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 26, 2026

Uh oh!

github-actions Bot commented Aug 26, 2026

Uh oh!

github-actions Bot commented Aug 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

abdulsaheel commented Aug 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Summary by Sourcery

PR Type

Description

Diagram Walkthrough

File Walkthrough

Summary by CodeRabbit

Uh oh!

sourcery-ai Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Flow diagram for registering localized profile languages

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

coderabbitai Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Sourcery assessment

Uh oh!

github-actions Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Reviewer Guide 🔍

(Review updated until commit 0874f78)

Uh oh!

github-actions Bot commented Aug 26, 2026

PR Code Suggestions ✨

Uh oh!

github-actions Bot commented Aug 26, 2026

Uh oh!

github-actions Bot commented Aug 26, 2026

PR Code Suggestions ✨

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

abdulsaheel commented Aug 26, 2026 •

edited by coderabbitai Bot

Loading

sourcery-ai Bot commented Aug 26, 2026 •

edited

Loading

coderabbitai Bot commented Aug 26, 2026 •

edited

Loading

github-actions Bot commented Aug 26, 2026 •

edited

Loading

(Review updated until commit `0874f78`)