Skip to content

x/y/z_airf_unrefined_dist are count means of unit vectors: not unit, not orthogonal, not area-weighted #404

Description

@1-Bort-1

calc_forces! (src/solver.jl, the unrefined aggregation block) sets x_airf_unrefined_dist, y_airf_unrefined_dist and z_airf_unrefined_dist to the plain mean over a section's panels of each panel's unit vector. On a curved or twisted section that mean is shorter than 1 and the three are no longer orthogonal; they are also unweighted, next to coefficients that #402 makes area-weighted. va_vec_unrefined_dist is a plain mean too.

Nothing in the repo reads these four fields (grep, 2026-09-30), so no result moves today.

What I would do: build the section frame from the area-weighted mean of y_airf and z_airf, Gram-Schmidt them and take x_airf = y × z (the same handedness as the panel frame), and area-weight va_vec. Whether an unrefined section frame should instead be the unrefined geometry's own frame (from its leading/trailing edge points) is the decision this needs.

Found in review of #402.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions