Repository navigation
fix(core): detect CharacteristicType from the opensemantic packages too - #212
Closed
SimonStier wants to merge 1 commit into
Closed
SimonStier wants to merge 1 commit into
SimonStier wants to merge 1 commit into
Conversation
- entities built from opensemantic.core.v1 derive from its CharacteristicType, not the one in osw.model.entity, so the generated schema was written flat instead of into $defs.generated - tolerate entity models without a meta field when tagging change ids
Contributor
Release previewMerging this PR would release v2.8.2 (current: Changelog preview (truncated)## v2.8.2 (2026-10-09)
### Bug Fixes
- Detect CharacteristicType from the opensemantic packages too
([`f195a97`](https://github.com/OpenSemanticLab/osw-python/commit/f195a973b141cf830c65656ab946ca454e7309aa))
Preview via python-semantic-release and conventional commits. |
Contributor
|
reopening under the correct account |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store_entitywrites the generated schema flat instead of into$defs.generatedwhen the entity comes from the releasedopensemanticpackages.The check only knows the locally generated class:
Characteristics built from
opensemantic.core.v1derive from that package'sCharacteristicType, not from the one inosw.model.entity, so theisinstancecheck fails and the mode staysROOT_LEVEL. The autogenerated half then lands at the root of the schema and overwrites the manually maintained part on the next save.Changes
CharacteristicTypefromopensemantic.core.v1as an optional dependency,Nonewhen the package is absentisinstancecheckchange_idtagging instore_entityagainst entity models without ametafield, which the same models hitFound while building
world.opensemantic.characteristics.quantitativev0.7.0, where 952 schema files came out flat. With the patch the diff drops to the 25 files that actually changed.