fix(ci): pin docker/login-action v4.6.0 to full SHA for SonarCloud - #104
Closed
cursor[bot] wants to merge 1 commit into
Closed
fix(ci): pin docker/login-action v4.6.0 to full SHA for SonarCloud#104cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Renovate PR #99 bumped docker/login-action to v4.6.0 using floating tags, which re-triggers SonarCloud rule githubactions:S7637 and fails the quality gate on main. Pin both GHCR and Quay login steps to the v4.6.0 commit SHA. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SonarCloud Code Analysis fails on
mainwith security rating C on new code (githubactions:S7637).Root cause
Renovate PR #99 bumped
docker/login-actiontov4.6.0using floating version tags in.github/workflows/docker-multiarch.yml, reintroducing the SonarCloud quality gate failure that was previously fixed in #71.Fix
Pin both GHCR and Quay login steps to the
v4.6.0release commit SHA (dbcb813823bdd20940b903addbd779551569679f).Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.