Skip to content

Adaptive Page Action visibility - #10

Merged
K4zoku merged 4 commits into
mainfrom
feat/adaptive-page-action-visibility
Sep 3, 2026
Merged

K4zoku merged 4 commits into
mainfrom
feat/adaptive-page-action-visibility

Conversation

@K4zoku

@K4zoku K4zoku commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Adaptive Page Action visibility:

  • The browser action now opens the same popup as the page action, with site settings shown by default.
  • The page action is shown only on sites that use the WebHID API through navigator.hid.
  • Setting option to hide Page action completely

Related issue(s)

Close #9

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Performance / Benchmark
  • Packaging / CI
  • Documentation
  • Tests
  • Other (please describe)

Testing

Manually tested on browser

Rust (daemon, NM host, mock)

  • cargo build --release passes, if the change touches Rust code
  • npm run lint:rs (cargo clippy) passes with no new warnings
  • npm run test:rs passes
  • Tested against a real HID device if the change touches enumeration,
    report descriptor parsing, or the data plane

Addon (JS)

  • npm run lint:js and npm run lint (web-ext) pass
  • npm run test:browser passes (no hardware needed)
  • npm run test:e2e passes if the change touches the data plane or
    worker-spawn paths (see E2E setup note below)
  • npm run test:benchmark if the change affects throughput or latency
  • Manually tested the changed area in the browser

Checklist

  • I've read CONTRIBUTING.md
  • My commit messages follow Conventional Commits style
  • I've updated relevant docs (README, DEVELOPMENT.md, ARCHITECTURE.md,
    BENCHMARK.md) if needed

@codacy-production

codacy-production Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 127 complexity · 10 duplication

Metric Results
Complexity 127
Duplication 10

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Comment thread tests/unit/content-ports.test.js Dismissed
@K4zoku
K4zoku merged commit 640c9b7 into main Sep 3, 2026
11 checks passed
@K4zoku
K4zoku deleted the feat/adaptive-page-action-visibility branch September 12, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Option to hide address bar button when WebHID is not used on page

2 participants