Skip to content

fix: CodeQL XSS, postMessage origin, and quality - #119

Merged
veillette merged 1 commit into
mainfrom
fix/codeql-security
Aug 12, 2026
Merged

fix: CodeQL XSS, postMessage origin, and quality#119
veillette merged 1 commit into
mainfrom
fix/codeql-security

Conversation

@veillette

Copy link
Copy Markdown
Collaborator

Summary

  • Prefer HTMLMediaElement.srcObject over createObjectURL + .src (js/xss-through-dom)
  • Reject non-same-origin messages in opencv-worker.js (js/missing-origin-check)
  • Remove unused confidence initializer (js/useless-assignment-to-local)

Test plan

  • Load a video / run OpenCV tracking smoke path
  • CodeQL alerts on webcam.ts and opencv-worker.js close after merge

Made with Cursor

Use video.srcObject for blob media, require same-origin worker
messages, and drop the dead confidence initializer.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@veillette
veillette merged commit 4314892 into main Aug 12, 2026
8 checks passed
@veillette
veillette deleted the fix/codeql-security branch August 12, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant