Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions requirements-release.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
python-semantic-release == 10.6.*
# GitPython 3.1.60 dropped Actor.name_email_regex, which python-semantic-release
# 10.6.1 still references; the release bump dies with
# "type object 'Actor' has no attribute 'name_email_regex'" before it does any
# git work. PSR depends on `gitpython~=3.0`, so the bad version floats in on a
# fresh install. Unpin once PSR ships a release compatible with 3.1.60+.
GitPython == 3.1.59
# Floor past the GitPython RCE fixes (GHSA-f9j4-qggq-h239, GHSA-83vg-56qc-22m7).
GitPython >= 3.2.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix: This raises the GitPython floor to 3.2.1, but the removed comment says python-semantic-release 10.6.1 still uses Actor.name_email_regex, which GitPython dropped in 3.1.60. Nothing in this PR shows that the python-semantic-release == 10.6.* version that gets resolved has stopped using it.

If it hasn't, the release bump fails with type object 'Actor' has no attribute 'name_email_regex' before doing any git work, and the release pipeline breaks.

Fix: confirm that a PSR release works with GitPython 3.2.x, then set the PSR pin to at least that version (e.g. python-semantic-release >= <fixed version>). Run a dry-run semantic-release version --print to check before merging.

Loading