Repository navigation
chore(deps): require GitPython >= 3.2.1 for release tooling #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
waninggibbon
wants to merge
1
commit into
OpenJobDescription:mainline
Choose a base branch
from
waninggibbon:chore/gitpython-3.2.1
base: mainline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,3 @@ | ||
| python-semantic-release == 10.6.* | ||
| # GitPython 3.1.60 dropped Actor.name_email_regex, which python-semantic-release | ||
| # 10.6.1 still references; the release bump dies with | ||
| # "type object 'Actor' has no attribute 'name_email_regex'" before it does any | ||
| # git work. PSR depends on `gitpython~=3.0`, so the bad version floats in on a | ||
| # fresh install. Unpin once PSR ships a release compatible with 3.1.60+. | ||
| GitPython == 3.1.59 | ||
| # Floor past the GitPython RCE fixes (GHSA-f9j4-qggq-h239, GHSA-83vg-56qc-22m7). | ||
| GitPython >= 3.2.1 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should fix: This raises the GitPython floor to 3.2.1, but the removed comment says python-semantic-release 10.6.1 still uses
Actor.name_email_regex, which GitPython dropped in 3.1.60. Nothing in this PR shows that thepython-semantic-release == 10.6.*version that gets resolved has stopped using it.If it hasn't, the release bump fails with
type object 'Actor' has no attribute 'name_email_regex'before doing any git work, and the release pipeline breaks.Fix: confirm that a PSR release works with GitPython 3.2.x, then set the PSR pin to at least that version (e.g.
python-semantic-release >= <fixed version>). Run a dry-runsemantic-release version --printto check before merging.