Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code_quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.9', '3.10', '3.11', '3.12']
python-version: ['3.10', '3.11', '3.12']

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Removing 3.9 from the matrix means no CI job runs on 3.9 on any OS, but pyproject.toml still has requires-python = ">=3.9" and the Python :: 3.9 classifier. Only ubuntu-latest lacks a 3.9 build; windows-latest and macos-latest can still run it. With nothing testing 3.9, a change that breaks 3.9 at runtime (e.g. stdlib APIs added in 3.10) would merge unnoticed and ship to 3.9 users.

You could keep 3.9 in the matrix and drop only the broken combination:

exclude:
  - os: ubuntu-latest
    python-version: '3.9'

The other option is to raise requires-python to 3.10 and remove the 3.9 classifier.

uses: OpenJobDescription/.github/.github/workflows/reusable_python_build.yml@mainline
with:
os: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v7
with:
python-version: '3.9'
python-version: '3.10'
- name: Install dependencies
run: |
pip install --upgrade hatch "virtualenv<21"
Expand Down
Loading