Repository navigation
Conversation
The caller of aws-deadline/.github's reusable release-train workflow, inert until the RELEASE_TRAIN_ENABLED variable is true. Dependabot no longer proposes openjd-* updates and the auto-approve job skips them: the release train owns those bumps. Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
…rganization Pass RELEASE_TRAIN_DISPATCH_TOKEN (OpenJobDescription repositories) and RELEASE_TRAIN_DISPATCH_TOKEN_AWS_DEADLINE (aws-deadline repositories) to the reusable workflow's per-organization dispatch secrets, in place of the release workflows' token. Both are optional; without one, that organization's downstream repositories pick a release up on their daily run. Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
seant-aws
force-pushed
the
release-train-caller
branch
from
November 5, 2026 20:45
1f45157 to
5620463
Compare
|
Claude review · advisory Reviewed Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking. Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The OpenJD release train re-releases this repository when an upstream OpenJD package releases (dependency bump, tests, release notes). It runs in AWS without a GitHub credential, so the repository's own workflow makes its GitHub writes.
What was the solution? (How)
.github/workflows/release_train.ymlcalls the reusable workflow from aws-deadline/.github#130 on a merge tomainline, on completion ofRelease: Publish, onworkflow_dispatchand daily at 06:17 UTC. After a release here it dispatches the release train of aws-deadline/deadline-cloud-worker-agent with a dedicated, bot-owned, Actions-only dispatch token per organization (optional; without one, those repositories' daily run picks the release up). In live mode the train opensbot/*dependency PRs for a maintainer to approve and squash-merge, then dispatches this repository's ownRelease: Bump..github/dependabot.ymlignoresopenjd-*andauto_approve.ymlno longer approves an openjd-* update, so Dependabot does not race the train. With the ignore in place the auto-approve guard is redundant; it stays as a second check.What is the impact of this change?
None until an admin enables it. The job is skipped unless the variable
RELEASE_TRAIN_ENABLEDistrue. To enable:RELEASE_TRAIN_ROLE: the ARN of the train's OIDC role (provided once the role is deployed in the team's account).RELEASE_TRAIN_MODE=liveandRELEASE_TRAIN_ENABLED=true.RELEASE_TRAIN_DISPATCH_TOKEN(fine-grained, resource owner OpenJobDescription, repositories openjd-model-for-python, openjd-sessions-for-python and openjd-cli, Actions read/write only) andRELEASE_TRAIN_DISPATCH_TOKEN_AWS_DEADLINE(fine-grained, resource owner aws-deadline, repository deadline-cloud-worker-agent, Actions read/write only) as repository or organization secrets. Both owned by a bot user, 90-day expiry, with a named rotation owner. Optional: without them, downstream repositories are picked up by their daily run.refs/heads/bot/**from theblock-branch-creationruleset.This PR depends on aws-deadline/.github#130.
How was this change tested?
actionlint and zizmor 1.32 (pedantic, with the aws-deadline zizmor policy) are clean. The same caller, pointed at fork branches, ran a release end to end on fork repositories, including the downstream dispatch.
Was this change documented?
Yes, in the workflow's header comment.
Is this a breaking change?
No.
Does this change impact security?
The job gets
contents,pull-requestsandactionswrite andid-token: write, used only by the reusable workflow's checked actions (bot/* branches only, never repository code). Only the dispatch step receives the dispatch tokens, and it uses each only for repositories of its own organization. The AWS role trusts only this repository'smainlinesubject; apull_requestrun can never assume it.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.