Conversation
… guides - Replace link:../../../opendj|openam/... paths to old product versions with cross-component xrefs to the current OpenDJ and OpenAM guides - Fix the row span in the managed.json script triggers table, which dropped the last row - Fix the hhttps typo in the SAP connector chapter - Drop the maven.forgerock.org download lines from the Groovy sample output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #232
Changes
Paths are relative to
openidm-doc/src/main/asciidoc.link:../../../opendj|openam/…is now a cross-component xref to the current guide and anchor, e.g.xref:opendj:admin-guide:chap-replication.adoc#read-ecl-as-regular-user[…].AntoraMojoleaves such xrefs unchanged (it only strips../and turns/into:). Besides the links listed in the issue, the same kind of link insamples-guide/chap-fullstack-sample.adoc:72and:130(openam/13/admin-guide) is fixed too.connectors-guide/chap-ldap.adoc: referential integrity is described in the OpenDJ Directory Server Developer's Guide, not the Administration Guide; the text now says so.integrators-guide/chap-passwords.adoc: the link points to the "LDAP Client Access Over SSL" section instead of the whole guide.window=\_blankis dropped from these links: an xref takes only the link text.integrators-guide/appendix-scripting.adoc: the "managed object config object" cell spans 7 trigger rows, not 6. The wrong row span shifted the cells and the last row (onValidate) was dropped.connectors-guide/chap-sap.adoc:hhttps→https.samples-guide/chap-groovy-samples.adoc: themaven.forgerock.orgdownload lines are removed from themvn installoutput.Verification
The site (doc.openidentityplatform.org,
master) was built with Antora before and after, with the changed pages converted the wayAntoraMojodoes:dropping cells from incomplete row detected end of tableinappendix-scripting.adocis gone; no other OpenIDM messages exceptmissing attribute;../../../,hhttpsormaven.forgerock;Not in this PR
custom-scripted-connector-bundler/src/main/resources/pom.templatestill usesorg.forgerock.openicf.connectors:connectors-parent:1.5.0.0frommaven.forgerock.org, so the Groovy sample does not build as written. Fixing it is a code change and belongs in a separate issue..github/build-baselineof the site repository can be removed.