[#1134] Give a VLV row of backendstat show-index-status its Confidential cell, so that its record count lands under Record Count - #1139
Merged
Conversation
…status its Confidential cell, so that its record count lands under Record Count
maximthomas
approved these changes
Oct 1, 2026
maximthomas
left a comment
Contributor
There was a problem hiding this comment.
praise: The fix goes into the one row that was short, and the new test fails on the old row shape in two separate ways.
appendStatsNoData(builder, 1)in the VLV loop ofappendIndexStatusTable(opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/BackendStat.java:1098) gives the VLV row a cell under each of the 9 headings, so its record count now sits under Record Count.- With that line reverted,
testShowIndexStatusPutsEachCellOfAVlvRowUnderItsHeadingwould fail on two separate assertions: the count would sit at the Confidential index (PluggableBackendImplTestCase.java:1230), and the row would carry a padded""cell (:1216). - CI run 36766766642 ran the inherited case green on all 11 storage suites: Cassandra ×2, JDBC ×5 (incl. MsSql, MySql, Oracle, PgSql), JE ×2 and PDB ×2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1134
backendstat show-index-statusprints 9 headings, but a VLV index row carried only 8 cells: its record count landed under Confidential,-under Record Count, and the 85% column was left empty.-)--, record count, 4 ×-BackendVLVIndexCfghas noconfidentiality-enabled, andVLVIndexkeeps no crypto suite), so its Confidential cell is-, like the other columns that do not apply to it.appendIndexStatusTable(builder, ec, undefinedKeys), split out ofshowIndexStatusso that a test can read the rows;showIndexStatuskeeps the lookup of the entry container, the printing and the error handling. Most of the diff inBackendStatis the re-indentation of that move (git diff -wshows the change itself).JDKLogging.disableLogging()moves from theBackendStatconstructor tomain(args, out, err), the only place the tool is constructed. The tool behaves as before; a test that constructs aBackendStatno longer resets the JDKLogManagerof the whole test JVM.Tests
PluggableBackendImplTestCase.testShowIndexStatusPutsEachCellOfAVlvRowUnderItsHeadingbuilds the table on the live backend of the suite, which has thepeopleVLV index, and captures it through aTablePrinterof its own. It checks that no row has an empty cell -TableBuilder.printpads a short row with"", so the size of a row alone says nothing - and that the VLV row shows-under Confidential, the record count read from the VLV tree under Record Count, and 4 ×-after it.["vlv.people", "/dc=com,dc=test/vlv.people", "true", "14", …]- the count under Confidential, the last cell empty.PDBTestCaseandJETestCase78/78 green. The JDBC and Cassandra suites inherit the test and run in CI.The reference partial
_variablelist-backendstat-index-status.adocadded by #1132 describes the Confidential column; it does not yet say that a VLV index shows-there.