Conversation
…e confirmed tasks, and say it does not accept the license
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1133
Problem
The description of
upgrade --force(INFO_UPGRADE_OPTION_FORCE_1741, shown byupgrade --helpand in the generated tools reference) says that long running or critical tasks which require user confirmation "will be skipped". The code does the opposite: in non-interactive mode with--force, the confirmation callback answers YES (UpgradeCli.handle), so every task gated byconfirmYN—rebuildAllIndexes, the JE / changelog / Local DB → PDB migrations — is performed. The license question is the only exception:Upgrade.checkLicenceanswers NO under--force, and--acceptLicenseis needed.Change
tool.properties: the--forcedescription now says the confirmed tasks "will be performed", and that the option does not accept the license — use--acceptLicense.UpgradeCli: passesOPTION_LONG_ACCEPT_LICENSEfor the new%s.The narrative in
install-guide/chap-upgrade.adocalready describes the real behaviour ("also performing long running and critical tasks") and is unchanged.Verification
Built with
mvn -pl opendj-server-legacy -am compile, then ran the compiledUpgradeCli:upgrade --help:-Dorg.forgerock.opendj.gendoc=true), which producesman-upgrade.adocfor the reference, renders the same text under`--force`::.No test is added: the change is message text only.