Skip to content

upgrade: the --force description says long running tasks are skipped, but --force performs them #1133

Description

@vharseko

The description of upgrade --force says the opposite of what the option does.

INFO_UPGRADE_OPTION_FORCE_1741, shown by upgrade --help and in the tools reference:

Forces a non-interactive upgrade to continue even if it requires user interaction. In particular, long running or critical upgrade tasks, such as re-indexing, which require user confirmation will be skipped.

In non-interactive mode with --force, the confirmation callback answers YES (UpgradeCli.java:480), so a task gated by a confirmation, e.g. rebuildAllIndexes (UpgradeTasks.java:576), is performed, not skipped. Without --force the default answer (NO) is taken. The license question is the exception: --force answers NO to it, and --acceptLicense is needed.

The upgrade description in the reference (DocBook description-upgrade.xml, now _description-upgrade.adoc in #1132) describes the actual behaviour: "You can add the --force option to force a non-interactive upgrade to continue in this case, also performing long running and critical tasks."

Expected: the option description says that long running or critical tasks requiring confirmation are performed (and that the license is not accepted by --force).

Found while fixing #1128.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugdocsupgradeUpgrading between versions and migrating from other directory servers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions