[#1160] Allow unescaped '=' in LDAPUtils dnRule attribute values - #1161
Open
nicholascowan wants to merge 1 commit into
Open
nicholascowan wants to merge 1 commit into
nicholascowan wants to merge 1 commit into
Conversation
…ttribute values RFC 4514 permits '=' inside DN attribute values; the dnRule regex added in OpenIdentityPlatform#436 rejected Google Workspace SAML entity IDs containing idpid=.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
=in the value (Google Workspace SAML entity IDs) #1160:LDAPUtils.dnRuleno longer rejects unescaped=inside DN attribute values (RFC 4514), so Google Workspace IdP entity IDs likehttps://accounts.google.com/o/saml2?idpid=12345can be stored in SMS.\=escaping working.Regression was introduced in #436.
Test plan
LDAPUtilsTest/testIsDNWithEqualsInValuepassestestIsDN/testIsDNInvalid/testIsDNInvalid2still passidpid=entity ID succeeds on OpenAM 16