fix(add-skill): resolve script path and install scope in docs

[onatozmenn]

HUMAN:

I ran the manifest tests, verified the documented fetch_skill.py flow installs the skill successfully from skills/add-skill, and confirmed npm run build:skills only regenerates the expected content.

---

Why

skills/add-skill/SKILL.md told the agent to run python3 <this-skill-path>/scripts/fetch_skill.py ..., but that placeholder is never defined anywhere, so the agent cannot resolve the script location and flails (#413). The same page also never states the install scope, which caused the global-vs-workspace confusion in the thread.

Summary

• Docs-only: run the bundled script from this skill's directory (python3 scripts/fetch_skill.py ..., matching the README and repo convention), instead of the unresolvable placeholder.
• State explicitly that installs are workspace-local (<workspace>/.agents/skills/<skill-name>/).
• Regenerated skills/index.js via npm run build:skills (content-only change).

Issue Number

Fixes #413

How to Test

• python -m pytest tests/test_interface_manifest.py -q → 16 passed (same on base).
• End-to-end of the documented flow: from skills/add-skill, python scripts/fetch_skill.py "OpenHands/extensions/skills/deno" <tmp-workspace> installs the skill's SKILL.md successfully.
• npm run build:skills regenerates skills/index.js; diff is content-only.

Notes: on a non-UTF-8 Windows console, fetch_skill.py's final success print raises UnicodeEncodeError after a successful install (cosmetic, locale-specific, out of scope here; happy to follow up separately).

Type

Bug fix

[all-hands-bot]

👋 This PR needs a couple of things fixed before OpenHands can review it:

• the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

[all-hands-bot]

👋 This PR needs a couple of things fixed before OpenHands can review it:

• the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

[all-hands-bot]

👋 This PR needs a couple of things fixed before OpenHands can review it:

• the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

[all-hands-bot]

👋 This PR needs a couple of things fixed before OpenHands can review it:

• the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

[all-hands-bot]

👋 This PR needs a couple of things fixed before OpenHands can review it:

• the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

[all-hands-bot]

👋 This PR needs a couple of things fixed before OpenHands can review it:

• the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

[Copilot]

🟡 Changes recommended

Real vendor manifests conflict with existing symlink-only tests, and the PR includes runtime changes beyond its documented docs-only scope.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates the add-skill documentation and generated catalog, while also adding vendor-manifest synchronization and GitHub automation profile behavior.

Changes:

• Clarifies script execution path and workspace-local installation.
• Supports real vendor manifest directories for Codex/Claude.
• Resolves AUTOMATION_MODEL profiles in github-repo-monitor.

File summaries

File	Description
skills/add-skill/SKILL.md	Documents the corrected install workflow.
skills/index.js	Regenerated skill catalog content.
scripts/sync_extensions.py	Adds real vendor manifest support.
skills/iterate/.codex-plugin/plugin.json	Adds Codex manifest copy.
skills/iterate/.claude-plugin/plugin.json	Adds Claude manifest copy.
tests/test_sync_extensions.py	Tests vendor manifest synchronization.
skills/github-repo-monitor/scripts/main.py	Adds LLM profile resolution.
tests/test_github_repo_monitor.py	Tests profile selection and fallback.

Review details

Files not reviewed (1)

• skills/index.js: Generated file

• Files reviewed: 9/10 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[all-hands-bot]

This review was posted by an AI agent (OpenHands).

Review: fix(add-skill): resolve script path and install scope in docs

Docs-only change to skills/add-skill/SKILL.md (plus the regenerated skills/index.js). I fetched the exact head 1356049c and verified the changed behavior against the workspace and the repository guidance in AGENTS.md.

What the change does, and why it is correct

• Replaces the never-defined placeholder python3 <this-skill-path>/scripts/fetch_skill.py with python3 scripts/fetch_skill.py, with the instruction to run it from the directory containing SKILL.md. This matches the documented usage in skills/add-skill/README.md (From the add-skill skill directory: python3 scripts/fetch_skill.py ...) and the convention used by other skills that ship scripts. The placeholder is now absent repo-wide (grep -rn 'this-skill-path' returns nothing), and fetch_skill.py still lives at skills/add-skill/scripts/fetch_skill.py, so the relative path resolves as described.
• The new install-scope note (<workspace>/.agents/skills/<skill-name>/, not global) matches the implementation: fetch_skill.py sets dest_dir = Path(workspace_path) / '.agents' / 'skills' / skill_name and copies there via shutil.copytree. It also matches the existing example in the same file (ls /path/to/workspace/.agents/skills/codereview/SKILL.md) and README.md. The wording is accurate and consistent with the repository's plain-hyphen punctuation convention.
• No side effects outside the reported bug: the call signature, argument order (<github-url> <workspace-path>), and the --force behavior are untouched, and the only other changed file is the generated catalog entry whose embedded content string mirrors SKILL.md exactly.

Verification performed

• Regenerated the catalog with node scripts/build-skills-catalog.mjs; git diff afterwards is empty, so the committed skills/index.js matches what the generator produces (content-only change, as claimed).
• Ran the focused suite: tests/test_interface_manifest.py, tests/test_add_skill_installs_to_agents_dir.py, tests/test_skills_catalog.py, tests/test_skills_have_readme.py -> 69 passed.
• python scripts/sync_extensions.py --check exits 0 (only a pre-existing non-blocking coverage warning for plugins/issue-duplicate-checker, unrelated to this PR).
• Reproduced the documented end-to-end flow from skills/add-skill: python3 scripts/fetch_skill.py "OpenHands/extensions/skills/deno" <tmp-workspace> succeeded and installed to <tmp-workspace>/.agents/skills/deno/ with SKILL.md present, confirming the workspace-local scope stated in the new note.
• GitHub Actions for head 1356049c: Validate PR description, check-pr-artifacts, and pr-title all pass.

No material bugs, security concerns, or design flaws found. The UnicodeEncodeError on non-UTF-8 Windows consoles noted in the PR description is a pre-existing, cosmetic, locale-specific issue in fetch_skill.py and is correctly out of scope for this docs fix.

✅ APPROVED

[neubig]

Thank you!