fix(iterate): ship real vendor manifest dirs for Codex install - #607

Open

onatozmenn wants to merge 2 commits into

OpenHands:mainfrom

onatozmenn:fix/iterate-codex-manifest

onatozmenn commented Sep 18, 2026 •

edited

Loading

HUMAN:

I ran the targeted VendorManifests tests and verified the lossy-copy case fails on base but passes with the fix, with no new failures or ruff issues beyond the existing ones.

Why

skills/iterate/.codex-plugin is a symlink to .plugin/, and Codex plugin add drops symlinked directories when materializing its install cache. The installed tree then has no .codex-plugin/plugin.json, so Codex fails with "missing or invalid plugin.json" and /iterate never registers (#257).

Summary

Replace skills/iterate/.codex-plugin and .claude-plugin symlinks with real directories containing byte-identical plugin.json copies (mode 120000 → 100644).
sync_symlinks now accepts a real vendor dir whose plugin.json mirrors the canonical one, flags stale copies, and refreshes them in fix mode; missing vendors still get symlinks as before.
New TestVendorManifests tests, including a lossy-install-copy simulation of the reported failure.

Issue Number

Fixes #257

How to Test

python -m pytest tests/test_sync_extensions.py -q -k VendorManifests → 4 passed, 2 skipped (symlink-creation tests skip on Windows without privileges; they run on Linux CI).
Lossy-copy test fails on base (manifest missing after symlink-dropping copy) and passes with the fix.
Full test_sync_extensions.py: the 7 remaining failures are identical on base (Windows-env frontmatter/catalog issues), no new failures. ruff check on touched files: no new findings (2 pre-existing F541s on base).

Type

Bug fix

github-actions Bot added the type: fix label

onatozmenn marked this pull request as ready for review

September 18, 2026 13:32

Copilot AI lite review requested due to automatic review settings

September 18, 2026 13:32

all-hands-bot commented Sep 18, 2026

Contributor

👋 This PR needs a couple of things fixed before OpenHands can review it:

the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

5 similar comments

all-hands-bot commented Sep 18, 2026

Contributor

👋 This PR needs a couple of things fixed before OpenHands can review it:

the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

all-hands-bot commented Sep 18, 2026

Contributor

👋 This PR needs a couple of things fixed before OpenHands can review it:

the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

all-hands-bot commented Sep 18, 2026

Contributor

👋 This PR needs a couple of things fixed before OpenHands can review it:

the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

all-hands-bot commented Sep 18, 2026

Contributor

👋 This PR needs a couple of things fixed before OpenHands can review it:

the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

all-hands-bot commented Sep 18, 2026

Contributor

👋 This PR needs a couple of things fixed before OpenHands can review it:

the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

Copilot started reviewing on behalf of onatozmenn

September 18, 2026 13:32

View session

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

🟡 Changes recommended

Existing plugin-loading tests still require vendor paths to be symlinks, so the full test suite will fail for iterate.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR fixes Codex installation by replacing iterate vendor manifest symlinks with real mirrored directories and updating synchronization checks. It also includes an unrelated GitHub repository monitor profile-resolution change.

Changes:

Add real .codex-plugin and .claude-plugin manifest copies.
Validate and refresh real vendor manifests in sync_extensions.py.
Add manifest/install tests and profile-resolution tests.

File summaries

File	Description
`scripts/sync_extensions.py`	Supports symlinked or mirrored vendor manifests.
`skills/iterate/.codex-plugin/plugin.json`	Adds Codex manifest copy.
`skills/iterate/.claude-plugin/plugin.json`	Adds Claude manifest copy.
`tests/test_sync_extensions.py`	Tests vendor manifest synchronization and lossy installs.
`skills/github-repo-monitor/scripts/main.py`	Adds LLM profile resolution.
`tests/test_github_repo_monitor.py`	Tests profile resolution behavior.

Review details

Files reviewed: 8/8 changed files
Comments generated: 2
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

tests/test_sync_extensions.py

Comment on lines +320 to +324

+                      for vendor in (".codex-plugin", ".claude-plugin"):
+                          path = iterate / vendor
+                          assert not path.is_symlink(), f"{vendor} must not be a symlink"
+                          assert path.is_dir(), f"{vendor} must be a real directory"
+                          assert (path / "plugin.json").read_bytes() == canon

skills/github-repo-monitor/scripts/main.py Outdated

Comment on lines +427 to +432

+                  profile = os.environ.get("AUTOMATION_MODEL")
+                  if profile:
+                      profile_llm = _fetch_profile_llm(agent_url, api_key, profile)
+                      if profile_llm is not None:
+                          llm = profile_llm
+                          llm["usage_id"] = f"profile:{profile}"


          fix(iterate): ship real vendor manifest dirs for Codex install

c1ee8ba

Co-authored-by: openhands <openhands@all-hands.dev>

onatozmenn force-pushed the fix/iterate-codex-manifest branch from a44d970 to c1ee8ba Compare

September 18, 2026 14:31


          test: accept real vendor manifest dirs in plugin loading checks

6d63d68

Co-authored-by: openhands <openhands@all-hands.dev>

onatozmenn commented Sep 18, 2026

Author

Follow-up on the review: the branch has been cleaned to just this fix, and the valid point about plugin-loading tests is addressed — test_all_marketplace_skills_have_vendor_manifests and test_has_vendor_manifests in tests/test_skill_plugin_loading.py now accept a real directory mirroring plugin.json alongside symlinks, matching the new sync rule. The iterate cases pass; remaining failures in that file are pre-existing Windows-checkout artifacts (symlinks materialize as files), identical on base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

At least 1 approving review is required to merge this pull request.

Labels