Repository navigation
Conversation
# Conflicts: # docs/how_to_guides/exploring_protocol_settings.nblink
Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
hannahbaumann
left a comment
Contributor
There was a problem hiding this comment.
Thanks @jthorton , lgtm, just left a few small comments!
|
|
||
| The number of lambda windows in each leg must match the number of replicas set in ``solvent_simulation_settings.n_replicas`` and ``vacuum_simulation_settings.n_replicas``. | ||
|
|
||
| For more information on configuring these and other protocol settings, see :doc:`Exploring protocol settings </how_to_guides/exploring_protocol_settings>`. |
Contributor
There was a problem hiding this comment.
Since that notebook doesn't show the absolute solvation settings (as far as I remember), should we maybe reword/remove this here?
Collaborator
Author
There was a problem hiding this comment.
Yeah I wasn't sure about this one, we mention it in the introduction but then don't show it in an example. We could add something to the guide to highlight that it acts like the other protocols but has the solvent and vacuum prefix?
Member
There was a problem hiding this comment.
I like the idea of adding a very small N.B. note.
Collaborator
Author
There was a problem hiding this comment.
added here OpenFreeEnergy/ExampleNotebooks#363
Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2278
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution:
Checklist
pre-commit.ci autofix.newsentry, or the changes are not user-facing.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin