Repository navigation
fix(ci): trigger website deployment after release - #296
Merged
Merged
Conversation
Releases created with GITHUB_TOKEN do not fire release events, so the website was never rebuilt on release. Dispatch website.yml explicitly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change that explicitly triggers website deployment after release creation.
No open issues 🎉
What changed in this PR
Ensures website deployment is triggered after Release Please creates a release, since releases created with GITHUB_TOKEN do not start other workflows through release events.
Changes:
- Exposes the Release Please
release_createdoutput. - Adds a conditional job that dispatches
website.ymlonmain, with the requiredactions: writepermission.
| File | Description |
|---|---|
.github/workflows/release-please.yml |
Connects successful release creation to an explicit website workflow dispatch. |
Review effort: Balanced
[Medium impact] The PR appears safe to merge.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases created by Release Please use
GITHUB_TOKEN, which does not trigger other workflows, so therelease: publishedtrigger inwebsite.ymlnever fired.Adds a
websitejob torelease-please.ymlthat runsgh workflow run website.ymlwhen a release was created (needsactions: write).