Repository navigation
fix(toolbar): exclude elements with negative tabindex from tab order audit - #294
Merged
Merged
Conversation
…audit Elements with tabindex below zero (e.g. -2, or -1 on links) are not reachable via the Tab key but were still listed in the tab order overlay. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
[Low impact] This PR appears safe to merge.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change excluding negative-tabindex elements from the tab-order overlay.
No open issues 🎉
What changed in this PR
Corrects the MageForge toolbar’s tab order audit so its numbered overlay excludes elements with any negative tabindex, including otherwise focusable links and buttons.
Changes:
- Filters candidates using
getTabIndex(el) >= 0before checking visibility and rendering the overlay.
| File | Description |
|---|---|
src/view/frontend/web/js/toolbar/audits/tab-order.js |
Excludes negative-tabindex elements from the tab order audit. |
Review effort: Balanced
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tab order audit selected
[tabindex]:not([tabindex="-1"])plusa[href]/buttonetc., so elements with a negative tabindex (e.g.-2, or-1on links) were still numbered although they cannot be reached via Tab.This filters out every candidate with a tabindex below zero before rendering the overlay.