Skip to content

Allow up to ten repair attempts#14

Merged
romgenie merged 1 commit into
mainfrom
agent/allow-ten-repair-attempts
Jul 15, 2026
Merged

Allow up to ten repair attempts#14
romgenie merged 1 commit into
mainfrom
agent/allow-ten-repair-attempts

Conversation

@romgenie

Copy link
Copy Markdown
Member

What changed

  • raise the automatic repair attempt ceiling from 3 to 10
  • add boundary coverage for attempts 9 and 10 and for values above the ceiling
  • update operator documentation to describe the effective 1-10 range

Why

Production policy now requests up to 10 repair attempts, but the worker currently clamps that value to 3. This makes the configured limit effective while preserving a finite fail-closed ceiling, repeated-finding detection, non-progress stops, validation requirements, and all diff/path safeguards.

The separate production policy rollout will allow at most 20 changed files per repair; the existing worker already enforces that value within its hard maximum of 50, so no source change is needed for the file limit.

Validation

  • npm test (113 passed)
  • npm run build
  • git diff --check

@covencat covencat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coven review

Status: success

Files inspected

Files inspected

  • README.md
  • docs/coven-github-connection.md
  • src/adapter.ts
  • tests/webhook-adapter.test.ts

Supporting context used

  • AGENTS.md — repository-level contribution/review constraints, if present, and to confirm there were no additional local instructions affecting review scope.
  • git diff --check receipt — trusted validation evidence showing the patch is whitespace-clean.

Findings

None

No-findings justification

I inspected the changed files listed in the review brief and the supporting repository guidance in AGENTS.md, then checked the implementation and tests at the touched areas in src/adapter.ts and tests/webhook-adapter.test.ts alongside the documentation updates in README.md and docs/coven-github-connection.md. The reviewed changes appear internally consistent: the adapter logic and its test coverage are aligned, and the documentation changes match the behavior described by the code. The trusted validation receipt shows git diff --check passed, with no formatting or patch hygiene issues detected.

Tests/commands considered

  • git diff --check - passed: whitespace/patch hygiene check completed successfully
  • Read on README.md, docs/coven-github-connection.md, src/adapter.ts, tests/webhook-adapter.test.ts, AGENTS.md - passed: inspected changed files and review constraints
  • Grep on src/adapter.ts, tests/webhook-adapter.test.ts, README.md - passed: targeted verification of event-trigger and test/documentation touchpoints

Confidence/limitations

None

Evidence

  • PR: #14
  • Base: main @ fba9084997626058c13a4b533764be65496080e6
  • Merge base: fba9084997626058c13a4b533764be65496080e6
  • Head: agent/allow-ten-repair-attempts @ 25247a034062bd27a75467cf8362e6b9c90ff76e
  • Checked-out workspace HEAD: 25247a034062bd27a75467cf8362e6b9c90ff76e
  • Changed files supplied to agent: 4
  • Review context SHA-256: c399b482305564ba5d3acad4a3ecdbc20bbf55d987b3a4fcd3546e45aa01df72
  • Files: README.md, docs/coven-github-connection.md, src/adapter.ts, tests/webhook-adapter.test.ts

Structured review

  • Mode: pull_request
  • Evidence status: complete
  • Reviewed files: 4
  • Reviewed file list: README.md, docs/coven-github-connection.md, src/adapter.ts, tests/webhook-adapter.test.ts
  • Supporting files inspected: 1
  • Supporting file list: AGENTS.md
  • Findings: 0
  • No-findings reason: I inspected the changed files listed in the review brief and the supporting repository guidance in AGENTS.md, then checked the implementation and tests at the touched areas in src/adapter.ts and tests/webhook-adapter.test.ts alongside the documentation updates in README.md and docs/coven-github-connection.md. The reviewed changes appear internally consistent: the adapter logic and its test coverage are aligned, and the documentation changes match the behavior described by the code. The trusted validation receipt shows git diff --check passed, with no formatting or patch hygiene issues detected.
  • Tests reported by runtime: 1
    • git diff --check: passed - Command completed successfully with no output.
  • Limitations: 0

Files changed: 0
Commits: 1

Task autoreview-8b0293b83f588f598e718ccc1ad81e39fb7fcf1960bae73b.

@romgenie
romgenie marked this pull request as ready for review July 15, 2026 03:23
@romgenie
romgenie merged commit 6a82b43 into main Jul 15, 2026
1 check passed
@romgenie
romgenie deleted the agent/allow-ten-repair-attempts branch July 15, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant