Fix Windows quota snapshot recovery - #263
Merged
Merged
Conversation
Accept only a fresh, complete bounded directory snapshot after an initial access denial while preserving isolated identity, entry limits, and fail-closed outcomes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bind the immutable harness revision, tree, workflow, and Windows supervisor bytes to the reviewed quota recovery commit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Windows supervisor, quota behavior, and conformance authority changes require final human review.
Pull request overview
Fixes Windows quota snapshot recovery by allowing a complete, bounded retry after transient access denial while preserving fail-closed safeguards.
Changes:
- Adds bounded readable-snapshot retry handling.
- Expands Windows quota, identity, ACL, and limit regression coverage.
- Regenerates supervisor authority pins and updates documentation.
File summaries
| File | Description |
|---|---|
src/phase1-conformance-lock.test.ts |
Validates authority pins. |
src/client-v1-conformance-workflow.test.ts |
Verifies embedded supervisor contracts. |
scripts/windows-quota-isolated-reader.test.ps1 |
Tests isolated-user snapshot behavior. |
scripts/windows-quota-diagnostics.test.ps1 |
Covers quota recovery diagnostics. |
scripts/windows-owner-directory-quota.test.ps1 |
Tests owner-directory quotas and limits. |
scripts/windows-job-supervisor.cs |
Implements bounded readable-snapshot recovery. |
phase1-conformance.lock.json |
Pins updated harness authority. |
docs/windows-quota-reproduction.md |
Documents recovery behavior and controls. |
docs/windows-quota-repeat-outcome.md |
Documents repeat outcomes. |
docs/phase1-conformance.md |
Updates conformance metadata and evidence. |
Review details
- Files reviewed: 10/11 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Unwrap only PowerShell and reflection invocation wrappers so the native fixture inspects the bounded quota context instead of discarding it for the deepest access exception. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Unwrap the production wrapper invocation inside the compiled Windows fixture so persistent denial assertions retain the bounded context exception. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Temporarily revert only for test-fixture ACL restoration, then require the retry enumeration to resume under the validated isolated identity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
corepack pnpm@10.34.0 test(normal suite passed; isolated rerun confirmed the one transient heavy deadline failure, then the full heavy suite passed)corepack pnpm@10.34.0 typecheckcorepack pnpm@10.34.0 lintcorepack pnpm@10.34.0 cargo:fmtcorepack pnpm@10.34.0 cargo:checkpwsh -NoLogo -NoProfile -NonInteractive -File scripts/windows-quota-diagnostics.test.ps1Tracks #219.