Repository navigation
fix: add C++ runtime libs for windows build - #152
Merged
Merged
Conversation
Collaborator
Author
|
@Jimmy385898 please approve the CI |
The old 6.4.3/msvc2019_64 toolchain no longer builds on the current windows runner, so bump Qt to 6.8.3/msvc2022_64. The deploy step still pointed windeployqt at the old 6.4.3/msvc2019_64 path, which no longer exists; align it so the Qt runtime bundling actually runs.
The windows package crashed on machines whose VC++ Redistributable is older than the toolset used to build it: msvcp140.dll 14.20 (VS2019) in System32 against a VS2022 (14.4x) build -> 0xc0000005 inside MSVCP140.dll while transcoding. windeployqt never ships the runtime DLLs (in release mode it only copies the vc_redist installer), so ship them app-local instead. - copy Microsoft.VC143.CRT\*.dll from the VS redist directory into OpenConverter_win64 (app-local wins over System32) - fail the build when vcruntime140.dll / vcruntime140_1.dll / msvcp140.dll are missing from the package - resolve windeployqt.exe via Get-Command (PATH) instead of a hard-coded path; install-qt-action@v3 puts <Qt>/bin on PATH and never exports QT_ROOT_DIR (that variable only exists in v4)
Jimmy385898
approved these changes
Sep 30, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows built produce could crash on old C++ runtime