Skip to content

feat: testing for actions PR 53 - #16

Draft
seantronsen wants to merge 2 commits into
seantronsen/testing-pr-52from
seantronsen/testing-pr-53
Draft

seantronsen wants to merge 2 commits into
seantronsen/testing-pr-52from
seantronsen/testing-pr-53

Conversation

@seantronsen

@seantronsen seantronsen commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Note

lint-makefile-common fails until v4.0 is released (see #11).

Testbed for OpenCHAMI/github-actions#53 (govulncheck findings uploaded as SARIF).

  • govulncheck.yml: moves check to the #53 head and grants it security-events: write for the SARIF upload.
  • README: adds a "Go vulnerabilities" testing note.

Expected:

  1. Base commit: govulncheck passes and uploads its SARIF (category govulncheck). Any findings are stdlib notes for symbols the code doesn't call.
  2. A follow-up commit adds github.com/dgrijalva/jwt-go v3.2.0+incompatible and calls MapClaims.VerifyAudience (GO-2020-0017) from an init in cmd/server/vulntest.go. The finding should show up in code scanning and on the PR, and govulncheck should fail on it.

Stacked on #15.

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.)
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Dependency update
  • Build system/CI

@seantronsen seantronsen changed the title Seantronsen/testing pr 53 feat: testing for actions PR 53 Oct 22, 2026
@seantronsen
seantronsen changed the base branch from main to seantronsen/testing-pr-52 October 22, 2026 14:39
@seantronsen
seantronsen added this pull request to stack #12 October 22, 2026 14:39
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen
seantronsen force-pushed the seantronsen/testing-pr-53 branch from 95d78d5 to 5158de0 Compare October 22, 2026 14:40
@seantronsen

Copy link
Copy Markdown
Collaborator Author

vulncheck confirmed. submitting faulty commit on purpose to test vulncheck sarif.

@github-actions

Copy link
Copy Markdown

Dependency Review

The following issues were found:
  • ❌ 1 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

Vulnerabilities

go.mod

NameVersionVulnerabilitySeverity
github.com/dgrijalva/jwt-go3.2.0+incompatibleAuthorization bypass in github.com/dgrijalva/jwt-gohigh
Only included vulnerabilities with severity high or higher.

License Issues

.github/workflows/govulncheck.yml

PackageVersionLicenseIssue Type
OpenCHAMI/github-actions/.github/workflows/govulncheck.yml9aa4f9e5a010d45cec4d108baacd1cdcb2aef40eNullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
actions/OpenCHAMI/github-actions/.github/workflows/govulncheck.yml 9aa4f9e5a010d45cec4d108baacd1cdcb2aef40e UnknownUnknown
gomod/github.com/dgrijalva/jwt-go 3.2.0+incompatible UnknownUnknown

Scanned Files

  • .github/workflows/govulncheck.yml
  • go.mod

@seantronsen seantronsen self-assigned this Oct 22, 2026
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen
seantronsen force-pushed the seantronsen/testing-pr-53 branch from 8a79661 to 9f37f7a Compare October 22, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants