You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for adding Qdrant support. I found a blocker in the non-demo indexing path.
QdrantIndexBackend.build_index() requires contents, but the non-demo Retriever.retriever_index() call only passes embeddings, ids, and overwrite. In addition, retriever_init() currently loads the corpus into self.contents only for FAISS/BM25, not Qdrant.
I reproduced it through the CLI on Windows with qdrant-client 1.18.0 and a local Qdrant path:
After configuring index_backend: qdrant, a JSONL corpus, and a matching precomputed .npy embedding file, ultrarag run examples/experiments/qdrant_index.yaml --param examples/experiments/parameter/qdrant_index_parameter.yaml fails in retriever_index with:
ToolError: [qdrant] 'contents' is required.
Could you load the corpus for Qdrant in the non-demo path and pass the contents aligned with the embedding rows into build_index()? A CLI-level regression test for ultrarag build + ultrarag run would also help cover the actual integration path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for using Qdrant as a vector search provider in UltraRAG.
Testing
I've unit tested this integration against a local Qdrant instance.
Setup
You can run Qdrant with
The Qdrant URL then will be
http://localhost:6333.The dashboard is accessible at http://localhost:6333/dashboard.