Repository navigation
focus_on: no check for an element without a role and a name - #1595
Merged
Merged
Conversation
An id or testid alone no longer makes a focus check: an unnamed focusable element (a bare tabindex div, a plain host whose closed shadow root holds the real focus) gets none, and the step stays vacuous, refused as before. focus_identity_is_specific agrees: an id or testid postcondition without a role and name asserts nothing and never passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
AI review (coordinator): approved. A strict tightening: an id or testid focus check now requires a role and a non-empty name, otherwise the step stays vacuous and refused, so the two review probes (a closed shadow root on a plain host, an unnamed div with a shifting id) can't pass. Arm once it's retargeted to main after #1579 merges, not while it's stacked. |
abrichr
enabled auto-merge
October 28, 2026 21:37
abrichr
added a commit
that referenced
this pull request
Oct 29, 2026
Bumps openadapt-flow to 2.4.1 (pyproject, __version__, the editable root in uv.lock) and writes the 2.4.1 changelog for everything user-visible merged since openadapt-flow-v2.4.0: #1593 (Windows config pin), #1594 (product code no longer imports the benchmark package), #1569 (div, grid and card worklist rows), #1539 (fault gate per class) and #1579/#1595 (focus_on). Regenerates llms-full.txt. Merging this publishes 2.4.1 through release-package.yml once main's Packages run for this commit passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow-up the #1579 review asked for, stacked on #1579. It retargets to main when #1579 merges.
Problem
A focusable element with no role or name, but with a bare id or testid, still got an id-only
focus_oncheck. Two probes from the review passed on the wrong element:divhost whose closed shadow root holds the real focus (the page sees only the host and its id);tabindexdiv whose unlisted id shifts by one render.Change
_focus_postcondition) creates no focus check for an element without a role and a non-empty accessible name, whatever its id or testid. The step stays vacuous and is refused as before. When a testid or id is used, the role and name are always bound with it.focus_identity_is_specificagrees: an id or testid postcondition without a role and name asserts nothing and never passes. focus_on: check who has the focus after a key that changes nothing visible #1579 isn't released, so no existing bundle depends on the old rule.Tests
In
tests/test_focus_on_postcondition.py, 33 tests pass:ruff, ruff format, mypy and strict mypy are clean.
🤖 Generated with Claude Code